Page MenuHomeFreeBSD

science/paraview: Unbreak build
ClosedPublic

Authored by jwb on Dec 12 2017, 1:49 PM.

Details

Summary

science/paraview: Unbreak build
PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216634

Approved by: jrm (mentor) or wen (mentor)
Differential to be added to commit log

Test Plan

portlint -C: Clean
Poudriere test running now on {10.3,11.1}-{amd64,i386}

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13516
Build 13740: arc lint + arc unit

Event Timeline

science/paraview/Makefile
32

Should this have the flavor-foo for the python version? Should this be done now or should the focus be only on fixing the build issue?

87–100

For future work, these could be converted to option helpers.

science/paraview/files/patch-Plugins_CDIReader_cdilib.c
1

It looks like just the timestamp changed here, so this change could/should be left out?

science/paraview/Makefile
32

It must, yes. Add @${PY_FLAVOR}.

Add Python flavor and silence REINPLACE_CMD.

In D13462#281369, @jwb wrote:

Add Python flavor and silence REINPLACE_CMD.

Also, RUN_DEPENDS= ... ${PYTHON_SITELIBDIR}/matplotlib/pyplot.py:math/py-matplotlib@${PY_FLAVOR}

I'm getting swamped again this morning, so I'll get back to these later when I can focus again...

Add python flavor to RUN_DEPENDS

Looks good. Don't forget the maintainer in the Approved by: field.

This revision is now accepted and ready to land.Dec 12 2017, 9:53 PM

Haven't heard from the maintainer yet. He submitted part of the patch on Aprll 6th and that's the last anyone heard from him. Should I try to reach out to him in case he didn't see the bugtracker updates?

The two week timeout could probably be considered to have started after Tobias's comment in August. You could 1) commit it noting the maintainer timeout, 2) confirm with portmgr that the timeout has been reached then commit it, or 3) contact the maintainer. In case of 3) you should wait two weeks.

In D13462#281494, @jrm wrote:

In case of 3) you should wait two weeks.

That is, wait two weeks if you don't hear back.

I think 4 months without a response to Tobias is enough. Just wanted to know if there are any strict rules about this situation. I'm going to let the last of 4 poudriere builds finish and then I'll do the commit assuming it succeeds.

This revision was automatically updated to reflect the committed changes.