Page MenuHomeFreeBSD
Differential D12892

devel/pear-SebastianBergmann_FinderFacade: Update and unbreak
ClosedPublic
Actions

Authored by joneum on Nov 1 2017, 9:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 14 2024, 2:48 AM
Unknown Object (File)
Feb 6 2024, 6:34 PM
Unknown Object (File)
Jan 19 2024, 2:20 AM
Unknown Object (File)
Jan 14 2024, 6:21 PM
Unknown Object (File)
Jan 8 2024, 4:57 AM
Unknown Object (File)
Jan 8 2024, 4:57 AM
Unknown Object (File)
Jan 8 2024, 4:56 AM
Unknown Object (File)
Jan 8 2024, 4:56 AM
View All 35 Files
Subscribers
mat

Details

Reviewers
tz
rene
tcberner
Commits
rP453998: devel/pear-SebastianBergmann_FinderFacade: Update from 1.1.0 to 1.2.1
Summary

devel/pear-SebastianBergmann_FinderFacade: Update from 1.1.0 to 1.2.1

Unbreak this port

switch to GitHub

Add NO_ARCH

Add LICENSE_FILE

Update *_DEPENDS

While here switch to DISTVERSION

Test Plan

~...devel/pear-SebastianBergmann_FinderFacade: portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: "RUN_DEPENDS" has to appear earlier.
0 fatal errors and 2 warnings found.

If I set "RUN_DEPENDS =" before "BUILD_DEPENDS =", portlint says: "WARN: Makefile:" BUILD_DEPENDS "has to appea earlier.

poudriere testport:

10.3-amd64
10.3-i386
10.4-amd64
10.4-i386
11.1-amd64
11.1-i386
12.0-CURRENT r325045 amd64
12.0-CURRENT r325045 i386

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12359
Build 12641: arc lint + arc unit

Event Timeline

joneum created this revision.Nov 1 2017, 9:19 AM
Herald added a subscriber: mat. · View Herald TranscriptNov 1 2017, 9:19 AM
joneum updated this revision to Diff 34591.Nov 1 2017, 9:36 AM

Add NO_ARCH

Harbormaster completed remote builds in B12359: Diff 34591.Nov 1 2017, 9:36 AM
tcberner added inline comments.Nov 1 2017, 6:11 PM
devel/pear-SebastianBergmann_FinderFacade/Makefile
10

^ why the change?

joneum added inline comments.Nov 1 2017, 6:41 PM
devel/pear-SebastianBergmann_FinderFacade/Makefile
10

was in vim for a better view

tcberner added a comment.Nov 1 2017, 6:43 PM
=======================<phase: build          >============================
===>  Building for pear-SebastianBergmann_FinderFacade-1.2.1
make[1]: cannot open Makefile.

make[1]: stopped in /wrkdirs/usr/ports/devel/pear-SebastianBergmann_FinderFacade/work/finder-facade-1.2.1
joneum added a comment.Nov 1 2017, 6:46 PM
In D12892#267681, @tcberner wrote:
=======================<phase: build          >============================
===>  Building for pear-SebastianBergmann_FinderFacade-1.2.1
make[1]: cannot open Makefile.

make[1]: stopped in /wrkdirs/usr/ports/devel/pear-SebastianBergmann_FinderFacade/work/finder-facade-1.2.1

?

tcberner added a comment.Nov 1 2017, 7:18 PM

You probably wanted NO_BUILD ?

joneum added a comment.Nov 1 2017, 8:03 PM
In D12892#267712, @tcberner wrote:

You probably wanted NO_BUILD ?

the same as into the other commits: https://svnweb.freebsd.org/changeset/ports/452650

tcberner added a comment.Nov 1 2017, 8:09 PM

The port has nothing to build, so you want a do-nada target :) i.e NO_BUILD=YES -- try to build this port, and you'll see the erorr -- unless something broke while applying this diff :)

joneum updated this revision to Diff 34634.Nov 1 2017, 8:37 PM

update

Harbormaster completed remote builds in B12382: Diff 34634.Nov 1 2017, 8:37 PM
mat added inline comments.Nov 2 2017, 2:37 PM
devel/pear-SebastianBergmann_FinderFacade/Makefile
23–36

Out of order. See Chapter 14. Order of Variables in Port Makefiles.

31

Any reason not to use DATADIR for this and have an extra PHP subdirectory ?

tcberner added inline comments.Nov 10 2017, 8:30 PM
devel/pear-SebastianBergmann_FinderFacade/Makefile
31

That might actually be a good idea. @joneum can you look into this?

joneum added a comment.Nov 11 2017, 7:20 PM

I do not want to change that. Many other pear ports are already like this.

tcberner accepted this revision.Nov 11 2017, 7:55 PM
In D12892#271213, @joneum wrote:

I do not want to change that. Many other pear ports are already like this.

If I recall correctly, we once talked about this directory, and both found that it is maybe not the right choice :D

This revision is now accepted and ready to land.Nov 11 2017, 7:55 PM
Closed by commit rP453998: devel/pear-SebastianBergmann_FinderFacade: Update from 1.1.0 to 1.2.1 (authored by joneum). · Explain WhyNov 11 2017, 8:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
pear-SebastianBergmann_FinderFacade/
35 lines
5 lines

Diff 34591

View Options

devel/pear-SebastianBergmann_FinderFacade/Makefile

Loading...
View Options

devel/pear-SebastianBergmann_FinderFacade/distinfo

Loading...