Page MenuHomeFreeBSD

devel/pear-SebastianBergmann_FinderFacade: Update and unbreak
ClosedPublic

Authored by joneum on Nov 1 2017, 9:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 8, 9:18 PM
Unknown Object (File)
Tue, Jul 29, 1:25 AM
Unknown Object (File)
Tue, Jul 29, 1:11 AM
Unknown Object (File)
Mon, Jul 28, 7:13 PM
Unknown Object (File)
Mon, Jul 28, 3:32 PM
Unknown Object (File)
Sun, Jul 27, 4:26 AM
Unknown Object (File)
Mon, Jul 21, 8:36 PM
Unknown Object (File)
Mon, Jul 21, 3:29 PM
Subscribers

Details

Summary

devel/pear-SebastianBergmann_FinderFacade: Update from 1.1.0 to 1.2.1

Unbreak this port

switch to GitHub

Add NO_ARCH

Add LICENSE_FILE

Update *_DEPENDS

While here switch to DISTVERSION

Test Plan

~...devel/pear-SebastianBergmann_FinderFacade: portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: "RUN_DEPENDS" has to appear earlier.
0 fatal errors and 2 warnings found.

If I set "RUN_DEPENDS =" before "BUILD_DEPENDS =", portlint says: "WARN: Makefile:" BUILD_DEPENDS "has to appea earlier.

poudriere testport:

10.3-amd64
10.3-i386
10.4-amd64
10.4-i386
11.1-amd64
11.1-i386
12.0-CURRENT r325045 amd64
12.0-CURRENT r325045 i386

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12358
Build 12640: arc lint + arc unit

Event Timeline

devel/pear-SebastianBergmann_FinderFacade/Makefile
10

^ why the change?

devel/pear-SebastianBergmann_FinderFacade/Makefile
10

was in vim for a better view

=======================<phase: build          >============================
===>  Building for pear-SebastianBergmann_FinderFacade-1.2.1
make[1]: cannot open Makefile.

make[1]: stopped in /wrkdirs/usr/ports/devel/pear-SebastianBergmann_FinderFacade/work/finder-facade-1.2.1
=======================<phase: build          >============================
===>  Building for pear-SebastianBergmann_FinderFacade-1.2.1
make[1]: cannot open Makefile.

make[1]: stopped in /wrkdirs/usr/ports/devel/pear-SebastianBergmann_FinderFacade/work/finder-facade-1.2.1

?

You probably wanted NO_BUILD ?

You probably wanted NO_BUILD ?

the same as into the other commits: https://svnweb.freebsd.org/changeset/ports/452650

The port has nothing to build, so you want a do-nada target :) i.e NO_BUILD=YES -- try to build this port, and you'll see the erorr -- unless something broke while applying this diff :)

devel/pear-SebastianBergmann_FinderFacade/Makefile
23–34
31

Any reason not to use DATADIR for this and have an extra PHP subdirectory ?

devel/pear-SebastianBergmann_FinderFacade/Makefile
31

That might actually be a good idea. @joneum can you look into this?

I do not want to change that. Many other pear ports are already like this.

I do not want to change that. Many other pear ports are already like this.

If I recall correctly, we once talked about this directory, and both found that it is maybe not the right choice :D

This revision is now accepted and ready to land.Nov 11 2017, 7:55 PM
This revision was automatically updated to reflect the committed changes.