This diff updates psi to its latest release and switches to Qt 5.
Details
- Reviewers
tcberner AMDmi3 - Group Reviewers
Contributor Reviewers (ports) - Commits
- rP470761: net-im/psi: Upgrade to 1.3.
poudriere testport on 11.1-RELEASE/amd64.
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 12271 Build 12562: arc lint + arc unit
Event Timeline
net-im/psi/Makefile | ||
---|---|---|
37–38 | Please use the CMAKE_BOOL helper. |
net-im/psi/Makefile | ||
---|---|---|
5 | To use instead of PORTVERSION. See 5.2.2. Versions, DISTVERSION or PORTVERSION | |
18 | The important bit is to always set a type for variables, :BOOL, :STRING... so that cmake does not have to guess from the content what you really meant. |
Use DISTVERSION instead of PORTVERSION.
net-im/psi/Makefile | ||
---|---|---|
18 | CMake uses type information only in cmake-gui to display right widget. It has no effect on code semantics. |
net-im/psi/Makefile | ||
---|---|---|
5 | There is no problem with versioning: $ pkg version -t 0.15 1.3 < I don't understand why we need DISTVERSION here, could you point it out? |
@mat , I think this patch is good to go, except DISTVERSIONor PORTVERSION part. I can take care of this.
The best way to get a patch committed, if you are not a committer yourself, is to open a PR with it. This, here, is a code review tool, not a place to put patches that other will need to commit.
net-im/psi/Makefile | ||
---|---|---|
14 | ^qca has been flavores, this should now be qca@qt5 | |
23 | ^ sort these by kind alphabetically -- I think it makes it easier to add/look for already present dependencies: USE_QT5= concurrentcore dbus gui multimedia network svg webkit widgets x11extras xml \ buildtools_build qmake_build \ imageformats_run [the last line break I can live without ^^ ] | |
25 | ^sort these alphabetically |
net-im/psi/Makefile | ||
---|---|---|
14 | ^ after thought: it also does not hurt in my opinion to sort the LIIB_DEPENDS alphabetically. -- same for the USES= |
Other than the little nitpick about USE_QT5= it looks fine to me.
net-im/psi/Makefile | ||
---|---|---|
17–18 | as mentioned above, I would not mix the _build and _run only dependencies into the others. |