net-im/psi: Update to 1.3

[arrowd]

Summary

This diff updates psi to its latest release and switches to Qt 5.

Test Plan

poudriere testport on 11.1-RELEASE/amd64.

[mat]

net-im/psi/Makefile

39–40

Please use the CMAKE_BOOL helper.

[arrowd]

Address comments.

[mat]

net-im/psi/Makefile

5

Please use DISTVERSION

7

No need to add a / here.

21

=0 is probably wrong, it should probably be :BOOL=false

30

What exactly is being debugged here?

[arrowd]

Address comments.

[arrowd]

net-im/psi/Makefile

5

Sorry, I don't get it. Why I need DISTVERSION here?

21

It was OK, actually, CMake treats 0, FALSE and NO as FALSE.

30

Nothing, forgot to remove.

[mat]

net-im/psi/Makefile

5

To use instead of PORTVERSION. See 5.2.2. Versions, DISTVERSION or PORTVERSION

21

The important bit is to always set a type for variables, :BOOL, :STRING... so that cmake does not have to guess from the content what you really meant.

[arrowd]

Use DISTVERSION instead of PORTVERSION.

net-im/psi/Makefile

21

CMake uses type information only in cmake-gui to display right widget. It has no effect on code semantics.

[arrowd]

Bump.

[lwhsu]

net-im/psi/Makefile

5

There is no problem with versioning:

$ pkg version -t 0.15 1.3
<

I don't understand why we need DISTVERSION here, could you point it out?

[arrowd]

net-im/psi/Makefile

5

It was @mat suggestion, I didn't get it too, tbh.

[arrowd]

Bump.

[arrowd]

Ping.

[lwhsu]

@mat , I think this patch is good to go, except DISTVERSIONor PORTVERSION part. I can take care of this.

[mat]

In D12778#302379, @6yearold_gmail.com wrote:

Ping.

The best way to get a patch committed, if you are not a committer yourself, is to open a PR with it. This, here, is a code review tool, not a place to put patches that other will need to commit.

[tcberner]

net-im/psi/Makefile

13

^qca has been flavores, this should now be qca@qt5

37

^ sort these by kind alphabetically -- I think it makes it easier to add/look for already present dependencies:

USE_QT5=         concurrentcore dbus gui multimedia network svg webkit widgets  x11extras xml \
                            buildtools_build qmake_build \
                            imageformats_run

[the last line break I can live without ^^ ]

39

^sort these alphabetically

[tcberner]

net-im/psi/Makefile

13

^ after thought: it also does not hurt in my opinion to sort the LIIB_DEPENDS alphabetically. -- same for the USES=

[arrowd]

Address comments.

[tcberner]

Other than the little nitpick about USE_QT5= it looks fine to me.

net-im/psi/Makefile

20–21

as mentioned above, I would not mix the _build and _run only dependencies into the others.