Page MenuHomeFreeBSD
Differential D12294

Add ptrace operations to fetch and store VFP registers.
ClosedPublic
Actions

Authored by jhb on Sep 9 2017, 2:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 4:25 AM
Unknown Object (File)
Mar 13 2025, 4:02 AM
Unknown Object (File)
Mar 1 2025, 1:36 PM
Unknown Object (File)
Feb 15 2025, 4:48 AM
Unknown Object (File)
Jan 24 2025, 9:07 AM
Unknown Object (File)
Jan 21 2025, 4:30 PM
Unknown Object (File)
Jan 2 2025, 2:54 AM
Unknown Object (File)
Dec 12 2024, 7:34 PM
View All 81 Files
Subscribers
andrew
emaste
ARM

Details

Reviewers
stevek
mmel
kib
Commits
rS323582: Add ptrace operations to fetch and store VFP registers.
Test Plan

This is part of a patch series to support VFP registers in gdb on armv7.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11566
Build 11919: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 9 2017, 2:37 PM
Herald added a subscriber: emaste. · View Herald TranscriptSep 9 2017, 2:37 PM
Harbormaster completed remote builds in B11454: Diff 32850.Sep 9 2017, 2:37 PM
jhb added a parent revision: D12293: Add a NT_ARM_VFP ELF core note to hold VFP registers for each thread..Sep 9 2017, 2:38 PM
stevek added a reviewer: stevek.Sep 9 2017, 3:16 PM
mmel accepted this revision.Sep 10 2017, 5:36 AM
This revision is now accepted and ready to land.Sep 10 2017, 5:36 AM
andrew added a subscriber: andrew.Sep 12 2017, 7:51 AM
andrew added inline comments.
sys/arm/include/ptrace.h
10

Where is this used?

jhb added inline comments.Sep 12 2017, 7:02 PM
sys/arm/include/ptrace.h
10

In userland consumers of the API (gcore and gdb).

jhb removed a parent revision: D12293: Add a NT_ARM_VFP ELF core note to hold VFP registers for each thread..Sep 12 2017, 7:44 PM
jhb added a parent revision: D12292: Only mess with VFP state on the CPU for curthread for get/set_vfpcontext..
jhb added a child revision: D12293: Add a NT_ARM_VFP ELF core note to hold VFP registers for each thread..
kib accepted this revision.Sep 14 2017, 2:35 PM
jhb updated this revision to Diff 33070.Sep 14 2017, 2:58 PM
  • Add explicit padding in vfpreg.
This revision now requires review to proceed.Sep 14 2017, 2:58 PM
Closed by commit rS323582: Add ptrace operations to fetch and store VFP registers. (authored by jhb). · Explain WhySep 14 2017, 3:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lib/
libc/
sys/
22 lines
sys/
arm/
arm/
63 lines
include/
15 lines
conf/
1 line

Diff 33070

View Options

lib/libc/sys/ptrace.2

Show First 20 Lines • Show All 275 Lines • ▼ Show 20 Linesparse_pci_mem_ranges(struct generic_pcie_softc *sc)
OF_getencprop(node, "#address-cells", &pci_addr_cells, OF_getencprop(node, "#address-cells", &pci_addr_cells,
sizeof(pci_addr_cells)); sizeof(pci_addr_cells));
OF_getencprop(node, "#size-cells", &size_cells, OF_getencprop(node, "#size-cells", &size_cells,
sizeof(size_cells)); sizeof(size_cells));
OF_getencprop(OF_parent(node), "#address-cells", &parent_addr_cells, OF_getencprop(OF_parent(node), "#address-cells", &parent_addr_cells,
sizeof(parent_addr_cells)); sizeof(parent_addr_cells));
if (parent_addr_cells != 2 || pci_addr_cells != 3 || size_cells != 2) { if (parent_addr_cells > 2 || pci_addr_cells != 3 || size_cells > 2) {
device_printf(sc->dev, device_printf(sc->dev,
"Unexpected number of address or size cells in FDT\n"); "Unexpected number of address or size cells in FDT\n");
return (ENXIO); return (ENXIO);
} }
nbase_ranges = OF_getproplen(node, "ranges"); nbase_ranges = OF_getproplen(node, "ranges");
sc->nranges = nbase_ranges / sizeof(cell_t) / sc->nranges = nbase_ranges / sizeof(cell_t) /
(parent_addr_cells + pci_addr_cells + size_cells); (parent_addr_cells + pci_addr_cells + size_cells);
▲ Show 20 Lines • Show All 689 Lines • Show Last 20 Lines
View Options

sys/arm/arm/ptrace_machdep.c

Show First 20 Lines • Show All 275 Lines • ▼ Show 20 Linesparse_pci_mem_ranges(struct generic_pcie_softc *sc)
OF_getencprop(node, "#address-cells", &pci_addr_cells, OF_getencprop(node, "#address-cells", &pci_addr_cells,
sizeof(pci_addr_cells)); sizeof(pci_addr_cells));
OF_getencprop(node, "#size-cells", &size_cells, OF_getencprop(node, "#size-cells", &size_cells,
sizeof(size_cells)); sizeof(size_cells));
OF_getencprop(OF_parent(node), "#address-cells", &parent_addr_cells, OF_getencprop(OF_parent(node), "#address-cells", &parent_addr_cells,
sizeof(parent_addr_cells)); sizeof(parent_addr_cells));
if (parent_addr_cells != 2 || pci_addr_cells != 3 || size_cells != 2) { if (parent_addr_cells > 2 || pci_addr_cells != 3 || size_cells > 2) {
device_printf(sc->dev, device_printf(sc->dev,
"Unexpected number of address or size cells in FDT\n"); "Unexpected number of address or size cells in FDT\n");
return (ENXIO); return (ENXIO);
} }
nbase_ranges = OF_getproplen(node, "ranges"); nbase_ranges = OF_getproplen(node, "ranges");
sc->nranges = nbase_ranges / sizeof(cell_t) / sc->nranges = nbase_ranges / sizeof(cell_t) /
(parent_addr_cells + pci_addr_cells + size_cells); (parent_addr_cells + pci_addr_cells + size_cells);
▲ Show 20 Lines • Show All 689 Lines • Show Last 20 Lines
View Options

sys/arm/include/ptrace.h

Show First 20 Lines • Show All 275 Lines • ▼ Show 20 Linesparse_pci_mem_ranges(struct generic_pcie_softc *sc)
OF_getencprop(node, "#address-cells", &pci_addr_cells, OF_getencprop(node, "#address-cells", &pci_addr_cells,
sizeof(pci_addr_cells)); sizeof(pci_addr_cells));
OF_getencprop(node, "#size-cells", &size_cells, OF_getencprop(node, "#size-cells", &size_cells,
sizeof(size_cells)); sizeof(size_cells));
OF_getencprop(OF_parent(node), "#address-cells", &parent_addr_cells, OF_getencprop(OF_parent(node), "#address-cells", &parent_addr_cells,
sizeof(parent_addr_cells)); sizeof(parent_addr_cells));
if (parent_addr_cells != 2 || pci_addr_cells != 3 || size_cells != 2) { if (parent_addr_cells > 2 || pci_addr_cells != 3 || size_cells > 2) {
device_printf(sc->dev, device_printf(sc->dev,
"Unexpected number of address or size cells in FDT\n"); "Unexpected number of address or size cells in FDT\n");
return (ENXIO); return (ENXIO);
} }
nbase_ranges = OF_getproplen(node, "ranges"); nbase_ranges = OF_getproplen(node, "ranges");
sc->nranges = nbase_ranges / sizeof(cell_t) / sc->nranges = nbase_ranges / sizeof(cell_t) /
(parent_addr_cells + pci_addr_cells + size_cells); (parent_addr_cells + pci_addr_cells + size_cells);
▲ Show 20 Lines • Show All 689 Lines • Show Last 20 Lines
View Options

sys/conf/files.arm

Show First 20 Lines • Show All 275 Lines • ▼ Show 20 Linesparse_pci_mem_ranges(struct generic_pcie_softc *sc)
OF_getencprop(node, "#address-cells", &pci_addr_cells, OF_getencprop(node, "#address-cells", &pci_addr_cells,
sizeof(pci_addr_cells)); sizeof(pci_addr_cells));
OF_getencprop(node, "#size-cells", &size_cells, OF_getencprop(node, "#size-cells", &size_cells,
sizeof(size_cells)); sizeof(size_cells));
OF_getencprop(OF_parent(node), "#address-cells", &parent_addr_cells, OF_getencprop(OF_parent(node), "#address-cells", &parent_addr_cells,
sizeof(parent_addr_cells)); sizeof(parent_addr_cells));
if (parent_addr_cells != 2 || pci_addr_cells != 3 || size_cells != 2) { if (parent_addr_cells > 2 || pci_addr_cells != 3 || size_cells > 2) {
device_printf(sc->dev, device_printf(sc->dev,
"Unexpected number of address or size cells in FDT\n"); "Unexpected number of address or size cells in FDT\n");
return (ENXIO); return (ENXIO);
} }
nbase_ranges = OF_getproplen(node, "ranges"); nbase_ranges = OF_getproplen(node, "ranges");
sc->nranges = nbase_ranges / sizeof(cell_t) / sc->nranges = nbase_ranges / sizeof(cell_t) /
(parent_addr_cells + pci_addr_cells + size_cells); (parent_addr_cells + pci_addr_cells + size_cells);
▲ Show 20 Lines • Show All 689 Lines • Show Last 20 Lines