Page MenuHomeFreeBSD
Differential D12099

Add minimal kernel runtime for UBSAN
Needs ReviewPublic
Actions

Authored by guest-svmhdvn on Aug 21 2017, 4:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 29, 8:36 AM
Unknown Object (File)
Fri, Jun 27, 10:36 AM
Unknown Object (File)
Tue, Jun 17, 5:59 PM
Unknown Object (File)
Mon, Jun 16, 7:26 AM
Unknown Object (File)
Thu, Jun 12, 11:47 PM
Unknown Object (File)
Wed, Jun 11, 11:12 PM
Unknown Object (File)
Tue, Jun 10, 12:02 PM
Unknown Object (File)
Tue, Jun 3, 11:21 AM
View All Files
Subscribers
andrew
lwhsu
op

Details

Reviewers
emaste
Summary

To use:

  1. Add options UBSAN to the kernel configuration file
  2. Add WITH_UBSAN=yes to src.conf(5) to enable UBSAN
  3. (optional) Add WITH_UBSAN_SANITIZE_ALL=yes to src.conf(5) to check all kernel source files for undefined behaviour

To check individual kernel source files with UBSAN, add compile-with "${NORMAL_C} ${ENABLE_UBSAN}" to the corresponding line in sys/conf/files. To disable UBSAN for individual files (even with WITH_UBSAN_SANITIZE_ALL=yes), add compile-with "${NORMAL_C} ${DISABLE_UBSAN}" to the corresponding line in sys/conf/files.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

guest-svmhdvn created this revision.Aug 21 2017, 4:05 PM
guest-svmhdvn updated this revision to Diff 32320.Aug 22 2017, 2:05 PM
guest-svmhdvn added a reviewer: emaste.

Add license after consulting with Ed

emaste added inline comments.Aug 22 2017, 2:51 PM
share/man/man5/src.conf.5
1512–1515 ↗(On Diff #32320)

src.conf.5 is generated automatically, via tools/build/options/makeman. You need to create WITH_ files in that directory.

sys/conf/NOTES
3042–3044

This should go up near INVARIANTS INVARIANT_SUPPORT DIAGNOSTIC etc., with a slightly longer description.

sys/conf/options
1005

also near INVARIANTS and other debugging options
Also something like # undefined behaviour sanitizer (ubsan) runtime - to highlight that it's only one part of the ubsan mechanism

sys/libkern/ubsan.c
349

probably need an assert that data->type_check_kind <= nitems(type_check_kinds)

guest-svmhdvn updated this revision to Diff 32322.Aug 22 2017, 3:47 PM
  • Moved around kernel options to correct locations and added additional comments
  • Added assert for checking bounds of array access
op added a subscriber: op.Aug 29 2017, 12:05 PM
op added inline comments.
sys/libkern/ubsan.c
111

FreeBSD style(9) requires parentheses after the return, like return (1 << (type->type_info >> 1)); and new line after { when there are no local variables.

guest-svmhdvn updated this revision to Diff 32482.Aug 29 2017, 2:40 PM

Fixed style(9) issues.

guest-svmhdvn updated this revision to Diff 32483.Aug 29 2017, 3:17 PM

Wrong commit order, accidentally deleted license.

emaste added a subscriber: andrew.Sep 13 2019, 7:23 PM
emaste added a comment.Mar 21 2023, 4:18 PM

NetBSD kernel ubsan imported in 0645126fae62300fe587199cf8eade00842cb9c1

lwhsu added a subscriber: lwhsu.Jul 15 2024, 4:37 AM

Revision Contents
Changeset List

PathSize
sys/
conf/
c/
sys/
conf/
8 lines
1 line
10 lines
3 lines
sys/
libkern/
369 lines

Diff 32322

View Options

sys/conf/NOTES

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/conf/kern.pre.mk

Loading...
View Options

sys/conf/options

Loading...
View Options

sys/libkern/ubsan.c

Loading...