The int increments are not consistent between loads/stores with multiple threads and may lose events during concurrent updates. tcpstats solves that problem with no real downsides.
Details
Details
- Reviewers
sbruno j-nitrology.com jtl - Group Reviewers
transport - Commits
- rS322900: Use counter(9) for PLPMTUD counters.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Looks good (with one minor nit inline).
| usr.bin/netstat/inet.c | ||
|---|---|---|
| 760 | Minor (yes, very minor) nit: On these three lines, the plural should probably be conditioned on the number. %s does this for you automatically. So, for example "...detection activation%s}\n". | |