Page MenuHomeFreeBSD

Use counter(9) for PLPMTUD counters
ClosedPublic

Authored by kbowling on Aug 12 2017, 5:32 AM.
Referenced Files
Unknown Object (File)
Thu, Apr 25, 11:26 AM
Unknown Object (File)
Feb 4 2024, 8:47 PM
Unknown Object (File)
Jan 31 2024, 1:12 AM
Unknown Object (File)
Jan 19 2024, 2:57 AM
Unknown Object (File)
Dec 19 2023, 11:59 PM
Unknown Object (File)
Nov 23 2023, 2:30 PM
Unknown Object (File)
Nov 8 2023, 1:57 AM
Unknown Object (File)
Oct 7 2023, 12:53 AM
Subscribers

Details

Summary

The int increments are not consistent between loads/stores with multiple threads and may lose events during concurrent updates. tcpstats solves that problem with no real downsides.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kbowling edited the summary of this revision. (Show Details)
jtl added a subscriber: jtl.

Looks good (with one minor nit inline).

usr.bin/netstat/inet.c
760

Minor (yes, very minor) nit: On these three lines, the plural should probably be conditioned on the number. %s does this for you automatically.

So, for example "...detection activation%s}\n".

This revision is now accepted and ready to land.Aug 14 2017, 1:08 PM
kbowling edited edge metadata.

Use the libxo plurals and fix the pmtud-failed label

This revision now requires review to proceed.Aug 14 2017, 6:54 PM

Noob question, should freebsdversion bump since this alters the ABI?

This revision was automatically updated to reflect the committed changes.