tests/sys/geom build warning fixes
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 9997 Build 10424: arc lint + arc unit
Event Timeline
Comment Actions
Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/3fda4ad7d4d0e1a11f6625f796fe8a80
- sys/geom/eli/pkcs5v2.c
- Warnings:
- warning: passing 'const char *' to parameter of type 'const uint8_t *' (aka 'const unsigned char *') converts between pointers to integer types with different sign [-Wpointer-sign]
- warning: passing 'uint8_t [11]' to parameter of type 'const char *' converts between pointers to integer types with different sign [-Wpointer-sign]
- Fixes:
- added the explicit modifier "const uint8_t *" to parameter "passphrase" to prepare it for the function on line 72
- added the explicit modifier "const char *" to parameter "passphrase" to prepare it for the function on line 103
- Warnings:
Comment Actions
Instead of casting to const char *, can you investigate actually changing and/or making the variable type consistent (either const char [] or const uint8_t [])?
Comment Actions
- tests/sys/geom build warning fixes
- tests/sys/geom revision update
Needed to change the variable to const char [], because the change to uint8_t [] would need to cause strcmp to be changed