@kib

Is the patch written in a way that it can be used when the inode size is 32-bit ?

Or are ifdefs needed ?

--HPS

In D10800#223705, @hselasky wrote:

@kib

Is the patch written in a way that it can be used when the inode size is 32-bit ?

Or are ifdefs needed ?

Patch is conditionally applied only when base has ino64 changes.

Why does webcamd sources (re)define dev_t ? If not this issue, patch could be applied unconditionally. In other words, you can take kernel/linux_func.c chunks and apply them to your source. kernel/linux_defs.h must be only applied on ino64, unless dev_t redefinition can be avoided.

Hi,

dev_t is used in conjunction with MKDEV() which is 32-bit. Did you test if webcamd breaks w/o this patch or is this patch a simple result of "grep -r" ? The dev_t should not be used in any FreeBSD kernel interfaces, only Linux ones.

--HPS

In D10800#223737, @hselasky wrote:

dev_t is used in conjunction with MKDEV() which is 32-bit. Did you test if webcamd breaks w/o this patch or is this patch a simple result of "grep -r" ? The dev_t should not be used in any FreeBSD kernel interfaces, only Linux ones.

This patch is result of fixing the build failure. I have no intend, nor I have any setup, to test webcamd at runtime.

Linux defines dev_t like this, and I think webcamd wants to keep it 32-bit.

include/linux/types.h:typedef u32 kernel_dev_t;
include/linux/types.h:typedef __kernel_dev_t dev_t;

Is it impossible to have webcamd define its own dev_t due to the header file pollution made by the ino64 patch?

In D10800#223740, @hselasky wrote:

Linux defines dev_t like this, and I think webcamd wants to keep it 32-bit.

include/linux/types.h:typedef u32 kernel_dev_t;
include/linux/types.h:typedef __kernel_dev_t dev_t;

Is it impossible to have webcamd define its own dev_t due to the header file pollution made by the ino64 patch?

ino64 patch does not introduce any header pollution.