Improve layout of struct inpcb
ClosedPublic
Actions

Authored by glebius on May 11 2017, 9:13 PM.

Details

Reviewers

Group Reviewers

network
transport

Commits

rS318793: o Rearrange struct inpcb fields to optimize the TCP output code path

Summary

Rearrange struct inpcb fields to optimize the TCP output code path considering cache line hits and misses. Put the lock and hash list glue into the first cache line, put inp_refcount inp_flags inp_socket into the second cache line. This has been tested at Netflix.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9214
Build 9663: CI src build	Jenkins
Build 9662: arc lint + arc unit

Event Timeline

glebius created this revision.May 11 2017, 9:13 PM

Harbormaster completed remote builds in B9214: Diff 28256.May 11 2017, 9:13 PM

Herald added a reviewer: transport. · View Herald TranscriptMay 11 2017, 9:13 PM

Herald added a subscriber: imp. · View Herald Transcript

jch added a subscriber: jch.May 11 2017, 9:19 PM

Harbormaster completed remote builds in B9214: Diff 28256.May 11 2017, 9:59 PM

gnn added a reviewer: bz.May 12 2017, 12:48 PM

Could this please be multiple individual changes.
The function argument change is completely independent of the struct reordering.

If people would want to do alternate performance validation on the struct changes, I'd really like to have just that.

Thanks.

This revision now requires changes to proceed.May 12 2017, 12:57 PM

Yes, this will be two separate commits.

Anybody is welcome to do alternate performance validation. At Netflix we found this layout of the structure optimal.

Reduce to the structure layout change only.

glebius retitled this revision from Tweaks and fixes to the inpcb allocation. to Improve layout of struct inpcb.May 15 2017, 10:03 PM

glebius edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B9290: Diff 28385.May 15 2017, 10:39 PM

Did the other changes get in already or are they in a different review? I will try to see what this one does in a different setup during the next days (I hope).

The other changes are already in.

glebius edited the summary of this revision. (Show Details)May 18 2017, 6:14 PM

Closed by commit rS318793: o Rearrange struct inpcb fields to optimize the TCP output code path (authored by glebius). · Explain WhyMay 24 2017, 5:47 PM

This revision was automatically updated to reflect the committed changes.

glebius mentioned this in rS318793: o Rearrange struct inpcb fields to optimize the TCP output code path.