Frames that are not considered for LRO should not be counted in LRO stats.
ClosedPublic
Actions

Authored by np on Apr 19 2017, 11:28 PM.

Tags

None

Referenced Files

	F165028037: D10430.id27701.diff
	Wed, Aug 5, 9:27 AM

	F164967357: D10430.id27561.diff
	Wed, Aug 5, 3:59 AM

	Unknown Object (File)
	Tue, Aug 4, 9:43 AM

	Unknown Object (File)
	Mon, Jul 27, 10:43 AM

	Unknown Object (File)
	Sun, Jul 26, 6:03 AM

	Unknown Object (File)
	Wed, Jul 22, 9:51 PM

	Unknown Object (File)
	Mon, Jul 20, 3:18 AM

	Unknown Object (File)
	Sun, Jul 19, 1:43 PM

Subscribers

Details

Reviewers

gnn
• hselasky
gallatin

Group Reviewers

network
transport

Commits

rS317389: Frames that are not considered for LRO should not be counted in LRO statistics.

Summary

The code will currently count any (even non-TCP) frame as queued/flushed
in the LRO stats if IFCAP_LRO is disabled or csum_flags is 0. It would
have been cleaner for tcp_lro_queue_mbuf to be able to return
TCP_LRO_CANNOT and let the caller figure out what to do. But I don't
want to touch the KPI and all the drivers so the proposed change fixes
the stats only.