Page MenuHomeFreeBSD

Frames that are not considered for LRO should not be counted in LRO stats.
ClosedPublic

Authored by np on Apr 19 2017, 11:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 10, 1:57 PM
Unknown Object (File)
Tue, Mar 10, 8:06 AM
Unknown Object (File)
Sat, Mar 7, 12:06 PM
Unknown Object (File)
Sat, Mar 7, 6:23 AM
Unknown Object (File)
Wed, Mar 4, 5:34 AM
Unknown Object (File)
Tue, Feb 17, 4:09 AM
Unknown Object (File)
Jan 18 2026, 11:25 AM
Unknown Object (File)
Jan 17 2026, 9:02 AM

Details

Summary

The code will currently count any (even non-TCP) frame as queued/flushed
in the LRO stats if IFCAP_LRO is disabled or csum_flags is 0. It would
have been cleaner for tcp_lro_queue_mbuf to be able to return
TCP_LRO_CANNOT and let the caller figure out what to do. But I don't
want to touch the KPI and all the drivers so the proposed change fixes
the stats only.

Diff Detail