Differential D10065

Handle kd == NULL gracefully with kvm_close(3)
ClosedPublic
Actions

Authored by ngie on Mar 20 2017, 6:08 PM.

Details

Reviewers

vangyzen

Group Reviewers

manpages

Commits

rS315647: Handle kd == NULL gracefully with kvm_close(3)

Summary

Handle kd == NULL gracefully with kvm_close(3)

Don't segfault in kvm_close(3) if provided a NULL pointer. Instead, return
-1 and set errno to EINVAL.

Document this new behavior explicitly.

MFC after: 1 week
Sponsored by: Dell EMC Isilon

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie created this revision.Mar 20 2017, 6:08 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 20 2017, 6:08 PM

Add kvm_open(3) manpage changes (oddly, arc diff --create didn't complain
about the second arg being invalid -- hah!)

Herald added a reviewer: manpages. · View Herald TranscriptMar 20 2017, 6:09 PM

ngie added inline comments.Mar 20 2017, 6:10 PM

lib/libkvm/kvm_open.3
247 ↗	(On Diff #26459)	This needs to be changed

Remove * before description of kd argument passed to kvm_close in the ERRORS section

vangyzen accepted this revision.Mar 20 2017, 6:22 PM

This revision is now accepted and ready to land.Mar 20 2017, 6:22 PM

Closed by commit rS315647: Handle kd == NULL gracefully with kvm_close(3) (authored by ngie). · Explain WhyMar 20 2017, 6:28 PM

This revision was automatically updated to reflect the committed changes.

ngie mentioned this in rS315647: Handle kd == NULL gracefully with kvm_close(3).

Harbormaster completed remote builds in B8159: Diff 26458.Mar 20 2017, 6:59 PM

Harbormaster failed remote builds in B8160: Diff 26459!Mar 20 2017, 7:03 PM

Harbormaster completed remote builds in B8161: Diff 26460.Mar 20 2017, 7:39 PM

ngie mentioned this in D10024: lib/libkvm: Start adding basic tests for kvm(3).Mar 21 2017, 9:06 PM

ngie mentioned this in rS316099: lib/libkvm: start adding basic tests for kvm(3).Mar 28 2017, 5:38 PM

ngie mentioned this in rS319006: MFC r316099:.May 27 2017, 11:05 PM

ngie mentioned this in rS319012: MFC r316099:.May 27 2017, 11:26 PM

Revision Contents
Changeset List

Path

Size

head/

lib/

libkvm/

kvm.c

4 lines

kvm_open.3

23 lines

Diff 26462

View Options

head/lib/libkvm/kvm.c