Page MenuHomeFreeBSD
Differential D10065

Handle kd == NULL gracefully with kvm_close(3)
ClosedPublic
Actions

Authored by ngie on Mar 20 2017, 6:08 PM.
Tags
None
Referenced Files
F168076186: D10065.diff
Wed, Aug 26, 6:40 AM
F168065350: D10065.id26462.diff
Wed, Aug 26, 5:21 AM
F168051948: D10065.id26460.diff
Wed, Aug 26, 3:49 AM
F168041340: D10065.id26459.diff
Wed, Aug 26, 2:19 AM
F168019320: D10065.id.diff
Tue, Aug 25, 11:04 PM
Unknown Object (File)
Mon, Aug 24, 7:21 PM
Unknown Object (File)
Mon, Aug 24, 4:12 PM
Unknown Object (File)
Mon, Aug 24, 2:17 AM
View All Files
Subscribers
imp
jhb
markj
vangyzen

Details

Reviewers
vangyzen
Group Reviewers
manpages
Commits
rS315647: Handle kd == NULL gracefully with kvm_close(3)
Summary

Handle kd == NULL gracefully with kvm_close(3)

Don't segfault in kvm_close(3) if provided a NULL pointer. Instead, return
-1 and set errno to EINVAL.

Document this new behavior explicitly.

MFC after: 1 week
Sponsored by: Dell EMC Isilon

Diff Detail

Event Timeline

ngie created this revision.Mar 20 2017, 6:08 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 20 2017, 6:08 PM
ngie updated this revision to Diff 26459.Mar 20 2017, 6:09 PM

Add kvm_open(3) manpage changes (oddly, arc diff --create didn't complain
about the second arg being invalid -- hah!)

Herald added a reviewer: manpages. · View Herald TranscriptMar 20 2017, 6:09 PM
ngie added inline comments.Mar 20 2017, 6:10 PM
lib/libkvm/kvm_open.3
247

This needs to be changed

ngie updated this revision to Diff 26460.Mar 20 2017, 6:11 PM

Remove * before description of kd argument passed to kvm_close in the ERRORS section

vangyzen accepted this revision.Mar 20 2017, 6:22 PM
This revision is now accepted and ready to land.Mar 20 2017, 6:22 PM
Closed by commit rS315647: Handle kd == NULL gracefully with kvm_close(3) (authored by ngie). · Explain WhyMar 20 2017, 6:28 PM
This revision was automatically updated to reflect the committed changes.
ngie mentioned this in rS315647: Handle kd == NULL gracefully with kvm_close(3).
Harbormaster completed remote builds in B8159: Diff 26458.Mar 20 2017, 6:59 PM
Harbormaster failed remote builds in B8160: Diff 26459!Mar 20 2017, 7:03 PM
Harbormaster completed remote builds in B8161: Diff 26460.Mar 20 2017, 7:39 PM
ngie mentioned this in D10024: lib/libkvm: Start adding basic tests for kvm(3).Mar 21 2017, 9:06 PM
ngie mentioned this in rS316099: lib/libkvm: start adding basic tests for kvm(3).Mar 28 2017, 5:38 PM
ngie mentioned this in rS319006: MFC r316099:.May 27 2017, 11:05 PM
ngie mentioned this in rS319012: MFC r316099:.May 27 2017, 11:26 PM

Revision Contents
Changeset List

PathSize
lib/
libkvm/
4 lines
21 lines

Diff 26459

View Options

lib/libkvm/kvm.c

Loading...
View Options

lib/libkvm/kvm_open.3

Loading...