Page MenuHomeFreeBSD
Differential D9559

snd_hda(4): reserve one more sequence number (14) for headphones redirection
AcceptedPublic
Actions

Authored by avos on Feb 12 2017, 7:14 PM.
Tags
None
Referenced Files
F159832134: D9559.id25055.diff
Thu, Jun 18, 3:33 PM
Unknown Object (File)
Wed, Jun 17, 1:01 PM
Unknown Object (File)
Wed, Jun 17, 1:28 AM
Unknown Object (File)
Wed, Jun 17, 1:27 AM
Unknown Object (File)
Mon, Jun 15, 12:29 PM
Unknown Object (File)
Sun, Jun 14, 8:23 PM
Unknown Object (File)
Fri, Jun 12, 9:25 PM
Unknown Object (File)
Wed, Jun 10, 7:13 AM
View All Files
Subscribers
bcr
imp
wblock

Details

Reviewers
mav
mmel
bcr
Group Reviewers
manpages
Summary

This will allow to handle one more additional output (one on the laptop + another one on the docking station in my case) for automatic speaker <-> headphones switch.

P.S. Probably, automatic association change (e.g., when all devices were disconnected) would be better here...

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

avos updated this revision to Diff 25055.Feb 12 2017, 7:14 PM
avos retitled this revision from to snd_hda(4): reserve one more sequence number (14) for headphones redirection.
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added reviewers: mmel, mav.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a reviewer: manpages. · View Herald TranscriptFeb 12 2017, 7:14 PM
Herald added a subscriber: imp. · View Herald Transcript
bcr added a subscriber: bcr.Feb 12 2017, 7:28 PM

Small grammar fix for the man page.

share/man/man4/snd_hda.4
230

s/has/have/

avos updated this revision to Diff 25061.Feb 12 2017, 7:36 PM
avos edited edge metadata.

s/has/have (twice)

Herald edited edge metadata. · View Herald TranscriptFeb 12 2017, 7:36 PM
avos marked an inline comment as done.Feb 12 2017, 7:37 PM
bcr accepted this revision.Feb 12 2017, 7:50 PM
bcr added a reviewer: bcr.

OK from the doc side of things.

This revision is now accepted and ready to land.Feb 12 2017, 7:50 PM
wblock added a subscriber: wblock.Feb 17 2017, 5:29 PM
wblock added inline comments.
share/man/man4/snd_hda.4
233

Remove "will" and reorder to remove the confusing aside (ignoring wrap, phabricator makes it hard to see where that needs to be):

duplicate the first pin in that assocation and provide automatic mute if jack detection is supported.
237

s/in/in an/

238

This sentence is hard to understand. Does "none of them" mean assocations or sequence numbers?

The last part is also unclear. Should it say "and there *is* more than one pin in *an* association"?

241

s/associations/associations,/

242

s/pairs/pair/

Revision Contents
Changeset List

PathSize
share/
man/
man4/
4 lines
sys/
dev/
sound/
pci/
hda/
20 lines

Diff 25055

View Options

share/man/man4/snd_hda.4

Loading...
View Options

sys/dev/sound/pci/hda/hdaa.c

Loading...