1) Add new rtld option to display error messages
AbandonedPublic
Actions

Authored by peterj on Jan 26 2017, 7:24 AM.

Details

Reviewers

kib
jhb

Group Reviewers

manpages

Summary

The runtime linker internally saves details of errors it encounters but
these are are only exposed if dlerror(3) is called. Setting LD_PRINT_ERROR
to a non-empty string will automatically print all errors detected by the
runtime linker to stderr.

MFC after: 1 week

Test Plan

Compile the following code and execute with and without LD_PRINT_ERROR set
to a non-empty string. Note that the error is printed twice, apparently
because there's a second attempt to resolve the missing symbol during the
program cleanup.

#include <dlfcn.h>
#include <err.h>
#include <stdio.h>

int main(int argc, char **argv)
{

if (dlsym(NULL, "symbol_missing") != NULL)
    errx(1, "Found unexpected symbol");
return (0);

}

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7031
Build 7211: arc lint + arc unit

Event Timeline

peterj updated this revision to Diff 24469.Jan 26 2017, 7:24 AM

peterj retitled this revision from to 1) Add new rtld option to display error messages.

peterj updated this object.

peterj edited the test plan for this revision. (Show Details)

peterj added reviewers: kib, jhb.

Herald added a reviewer: manpages. · View Herald TranscriptJan 26 2017, 7:24 AM

Herald added a subscriber: imp. · View Herald Transcript

I must note that for my whole-time usage of FreeBSD, I never needed such functionality. Rather, when I needed anything close to the proposed patch, I needed much more information, enabled by the LD_DEBUG knob. The only complication with LD_DEBUG is that we still do not compile rtld in this mode by default, but recompilation is trivial.

Also I am not convinced that adding a verbose features to the userspace runtime components is safe, the printing depends on too many assumptions about the program environment, like that the fd 2 is stderr, printing into it is safe etc.

Wouldn't utrace patch enough to diagnose ?

libexec/rtld-elf/rtld.c
457	Compare your usage of the LD prefix wrapping and the same usage one line above.

wblock added a subscriber: wblock.Jan 27 2017, 5:48 PM

wblock added inline comments.

libexec/rtld-elf/rtld.1
205	Is this still valid if we make it more active? to print error messages that are available to the application from (Also avoiding "via", which only seems valid to me when given with a network or highway-type map.)