This patch adds capsicum support to the users binary.
Details
Details
Run users with no arguments, works well.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 6566 Build 6787: arc lint + arc unit
Event Timeline
| usr.bin/users/users.cc | ||
|---|---|---|
| 58 | Does this need to include errno.h to compile? | |
Comment Actions
Does this need to include errno.h to compile?
It compiles without, but you're right in that it should. The only reason it does compile is that some header somewhere also includes errno.h
Comment Actions
- Updating D9046: Capsicum: add capability mode to users binary #
- Enter a brief description of the changes included in this update.
- The first line is used as subject, next lines as comment. #
- If you intended to create a new revision, use:
- $ arc diff --create
Updated to include extra err.h and errno.h
Comment Actions
It's look good with me.
To be super precise we could consider limiting standard descriptors (std{in, out, err}).
Comment Actions
This is a valid point, but I'm willing to trade off simplicity and smaller changes against precisely limiting stdio on trivial utilities like this.