Page MenuHomeFreeBSD
Differential D8953

sfxge(4): do not use enum for filter flags
ClosedPublic
Actions

Authored by arybchik on Dec 28 2016, 4:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 27, 8:15 PM
Unknown Object (File)
Mon, Apr 20, 12:16 AM
Unknown Object (File)
Sun, Apr 19, 7:12 PM
Unknown Object (File)
Apr 10 2026, 6:47 PM
Unknown Object (File)
Mar 18 2026, 4:57 AM
Unknown Object (File)
Mar 18 2026, 4:57 AM
Unknown Object (File)
Mar 16 2026, 1:16 AM
Unknown Object (File)
Mar 2 2026, 4:29 AM
View All 91 Files
Subscribers
imp

Details

Reviewers
philip
np
gnn
bz
Commits
rS310755: sfxge(4): do not use enum for filter flags
Summary

It is not 100% correct to assign non-enum values to enum type
variables.

Found by ICC build (DPDK PMD upstreaming).

Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

amd64 kernels tinderbox build tested

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6432
Build 6664: arc lint + arc unit

Event Timeline

arybchik updated this revision to Diff 23341.Dec 28 2016, 4:25 PM
arybchik retitled this revision from to sfxge(4): do not use enum for filter flags.
arybchik updated this object.
arybchik edited the test plan for this revision. (Show Details)
arybchik added reviewers: gnn, philip, np, bz.
Herald added a subscriber: imp. · View Herald TranscriptDec 28 2016, 4:25 PM
gnn accepted this revision.Dec 28 2016, 4:44 PM
gnn edited edge metadata.
This revision is now accepted and ready to land.Dec 28 2016, 4:44 PM
Closed by commit rS310755: sfxge(4): do not use enum for filter flags (authored by arybchik). · Explain WhyDec 29 2016, 7:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
common/
10 lines
32 lines
2 lines

Diff 23341

View Options

head/sys/dev/sfxge/common/ef10_filter.c

Loading...
View Options

head/sys/dev/sfxge/common/efx.h

Loading...
View Options

head/sys/dev/sfxge/common/efx_filter.c

Loading...