Page MenuHomeFreeBSD
Differential D8740

remove network mask calculation for Classful network
ClosedPublic
Actions

Authored by kczekirda on Dec 9 2016, 10:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 8:33 AM
Unknown Object (File)
Sat, Nov 23, 4:05 AM
Unknown Object (File)
Sun, Nov 17, 4:56 PM
Unknown Object (File)
Wed, Nov 13, 9:26 AM
Unknown Object (File)
Oct 20 2024, 4:10 AM
Unknown Object (File)
Oct 20 2024, 4:10 AM
Unknown Object (File)
Oct 20 2024, 4:10 AM
Unknown Object (File)
Oct 20 2024, 4:10 AM
View All Files
Subscribers
glebius

Details

Reviewers
freebsd-net-list
glebius
bapt
imp
• ian
oshogbo
tsoome
Group Reviewers
network
Commits
rS317886: distinguish NFS versus TFTP boot by rootpath
rS312930: MFC r311659:
rS311659: remove network mask calculation for Classful network
Summary

Nowadays it's not necessary to compute network mask from the IP address and compare to given by DHCP.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kczekirda updated this revision to Diff 22776.Dec 9 2016, 10:54 AM
kczekirda retitled this revision from to remove network mask calculation for Classful network.
kczekirda updated this object.
kczekirda edited the test plan for this revision. (Show Details)
kczekirda added reviewers: bapt, imp, • ian.
kczekirda updated this revision to Diff 22777.Dec 9 2016, 10:56 AM
kczekirda added a reviewer: tsoome.Dec 9 2016, 12:08 PM
tsoome edited edge metadata.Dec 9 2016, 12:19 PM

There is an problem - not enough context. You can use arcanist, or just tell svn diff to include more {all} lines.

kczekirda updated this revision to Diff 22778.Dec 9 2016, 12:37 PM
kczekirda edited edge metadata.
kczekirda updated this revision to Diff 22781.Dec 9 2016, 5:24 PM
kczekirda added a reviewer: oshogbo.Dec 10 2016, 12:06 PM
tsoome added a comment.Dec 10 2016, 12:11 PM

IMO it seems to make sense, but there is the question, how much testing have you done, any class[less] tests?

kczekirda added a comment.Dec 12 2016, 3:35 PM

Tested on:

  • 192.168.1.0/24
  • 192.168.1.0/25
  • 10.0.0.0/16
  • 10.0.0.0/24
  • 176.119.56.0/22
kczekirda added a reviewer: network.Dec 12 2016, 3:35 PM
tsoome accepted this revision.Dec 12 2016, 4:15 PM
tsoome edited edge metadata.

Seems good, I think.

This revision is now accepted and ready to land.Dec 12 2016, 4:15 PM
glebius requested changes to this revision.Dec 12 2016, 9:16 PM
glebius added a reviewer: glebius.
glebius added a subscriber: glebius.

This revision will make BOOTP incompatible towards old classful BOOTP server. If a BOOTP server doesn't supply mask at all, you will end with zero mask.

Of course, the class mask shall not override mask supplied from server. But support for classes should remain, it doesn't hurt. So, the whole code removed should remain, but wrapped into "if (!smask) { }".

This revision now requires changes to proceed.Dec 12 2016, 9:16 PM
kczekirda updated this revision to Diff 22858.Dec 13 2016, 5:43 AM
kczekirda edited edge metadata.

It's should enough for backwards compatibility.

kczekirda added a reviewer: freebsd-net-list.Dec 14 2016, 11:12 PM
glebius accepted this revision.Dec 15 2016, 6:55 PM
glebius edited edge metadata.

This looks correct to me. But I haven't reviewed the consequences of writing directly to the "netmask", which is also shared with rarp.c and udp.c

Thanks!

This revision is now accepted and ready to land.Dec 15 2016, 6:55 PM
bapt accepted this revision.Jan 7 2017, 11:37 PM
bapt edited edge metadata.
Closed by commit rS311659: remove network mask calculation for Classful network (authored by bapt). · Explain WhyJan 7 2017, 11:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr/
src/
lib/
libstand/
bootp.c
bootp.c.bak
32 lines

Diff 22776

View Options

/usr/src/lib/libstand/bootp.c

Loading...