Page MenuHomeFreeBSD
Differential D8018

Mount msdosfs with longnames support by default.
ClosedPublic
Actions

Authored by asomers on Sep 23 2016, 4:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 12, 2:22 AM
Unknown Object (File)
Mon, Mar 31, 11:22 PM
Unknown Object (File)
Feb 20 2025, 5:05 PM
Unknown Object (File)
Feb 20 2025, 4:20 PM
Unknown Object (File)
Feb 18 2025, 10:18 AM
Unknown Object (File)
Feb 17 2025, 8:52 AM
Unknown Object (File)
Feb 9 2025, 8:18 AM
Unknown Object (File)
Dec 26 2024, 7:12 AM
View All 93 Files
Subscribers
cem

Details

Reviewers
cem
trasz
wblock
imp
adrian
Group Reviewers
manpages
Commits
rS306276: Mount msdosfs with longnames support by default.
Summary

Mount msdosfs with longnames support by default.

The old behavior depended on the FAT version and on what files were in the
root directory. "mount_msdosfs -o shortnames" is still supported.

Test Plan

Create short and long filenames in a subdirectory on FAT12, 16, and 32
filesystems. Mount them with and without -o shortnames and verify that all
filenames are displayed correctly.

Diff Detail

Event Timeline

asomers updated this revision to Diff 20650.Sep 23 2016, 4:55 PM
asomers retitled this revision from to Mount msdosfs with longnames support by default..
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added reviewers: imp, trasz, adrian.
Herald added a reviewer: manpages. · View Herald TranscriptSep 23 2016, 4:55 PM
asomers updated this revision to Diff 20651.Sep 23 2016, 4:59 PM
asomers edited edge metadata.

Add sys/sys/param.h to the review

Herald edited edge metadata. · View Herald TranscriptSep 23 2016, 4:59 PM
cem accepted this revision.Sep 23 2016, 5:51 PM
cem added a reviewer: cem.
cem added a subscriber: cem.

There's no reason not to support Win95 long file names ("LFN") by default. Long names are purely backwards compatible with shortname-only filesystems.

Pre-win95 Microsoft systems w/out LFN support can even mount and browse filesystems with LFN entries, due to the fallback 8.3 encoding. If they mount r/w and modify directories, they might destroy the LFN names, but I do not think this is our problem.

This revision is now accepted and ready to land.Sep 23 2016, 5:51 PM
wblock accepted this revision.Sep 23 2016, 6:02 PM
wblock added a reviewer: wblock.
Closed by commit rS306276: Mount msdosfs with longnames support by default. (authored by asomers). · Explain WhySep 23 2016, 7:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sbin/
mount_msdosfs/
9 lines
sys/
fs/
msdosfs/
1 line
52 lines
20 lines

Diff 20650

View Options

sbin/mount_msdosfs/mount_msdosfs.8

# Created by: Devon H. O'Dell <devon.odell@gmail.com> # Created by: Devon H. O'Dell <devon.odell@gmail.com>
# $FreeBSD$ # $FreeBSD$
PORTNAME= go PORTNAME= go
PORTVERSION= 1.14.2 PORTVERSION?= 1.14.2
PORTEPOCH= 1 PORTREVISION?= 0
PORTEPOCH?= 1
CATEGORIES= lang CATEGORIES= lang
MASTER_SITES= https://golang.org/dl/ \ MASTER_SITES?= https://golang.org/dl/ \
https://github.com/dmgk/go-bootstrap/releases/download/${BOOTSTRAP_TAG}/:bootstrap \ https://github.com/dmgk/go-bootstrap/releases/download/${BOOTSTRAP_TAG}/:bootstrap \
LOCAL/dmgk:bootstrap LOCAL/dmgk:bootstrap
DISTFILES= go${PORTVERSION}.src.tar.gz \ DISTFILES?= go${PORTVERSION}.src.tar.gz \
go-${OPSYS:tl}-${GOARCH_${ARCH}}${GOARM_${ARCH}}-${BOOTSTRAP_TAG}.tar.xz:bootstrap go-${OPSYS:tl}-${GOARCH_${ARCH}}${GOARM_${ARCH}}-${BOOTSTRAP_TAG}.tar.xz:bootstrap
MAINTAINER= dmgk@FreeBSD.org MAINTAINER= dmgk@FreeBSD.org
COMMENT= Go programming language COMMENT?= Go programming language
tobikUnsubmitted
Done
Inline Actions

Oh, COMMENT also needs ?=.

tobik: Oh, COMMENT also needs `?=`.
dmgkAuthorUnsubmitted
Done
Inline Actions

Thanks for catching these.

dmgk: Thanks for catching these.
LICENSE= BSD3CLAUSE LICENSE= BSD3CLAUSE
LICENSE_FILE= ${WRKSRC}/LICENSE LICENSE_FILE= ${WRKSRC}/LICENSE
.ifdef QEMU_EMULATING .ifdef QEMU_EMULATING
IGNORE= fails to build with qemu-user-static IGNORE= fails to build with qemu-user-static
.endif .endif
ONLY_FOR_ARCHS= aarch64 amd64 armv6 armv7 i386 ONLY_FOR_ARCHS= aarch64 amd64 armv6 armv7 i386
RUN_DEPENDS= ${RUN_DEPENDS_${ARCH}} RUN_DEPENDS= ${RUN_DEPENDS_${ARCH}}
# ld.bfd from devel/binutils is needed for working cgo on aarch64 # ld.bfd from devel/binutils is needed for working cgo on aarch64
RUN_DEPENDS_aarch64= binutils>0:devel/binutils RUN_DEPENDS_aarch64= binutils>0:devel/binutils
TEST_DEPENDS= ${TEST_DEPENDS_${ARCH}} TEST_DEPENDS= ${TEST_DEPENDS_${ARCH}}
TEST_DEPENDS_aarch64= binutils>0:devel/binutils TEST_DEPENDS_aarch64= binutils>0:devel/binutils
USES= shebangfix USES= shebangfix
SHEBANG_FILES= misc/wasm/go_js_wasm_exec \ SHEBANG_FILES= misc/wasm/go_js_wasm_exec \
src/net/http/cgi/testdata/test.cgi src/net/http/cgi/testdata/test.cgi
SHEBANG_GLOB= *.bash *.pl *.sh SHEBANG_GLOB= *.bash *.pl *.sh
sh_OLD_CMD= /bin/bash "/usr/bin/env bash"
sh_CMD= ${SH}
tobikUnsubmitted
Done
Inline Actions

Unrelated to this review, but these are now flagged by portscan/portclippy. Can you drop them? Without setting SHEBANG_LANG=sh they are unused.

tobik: Unrelated to this review, but these are now flagged by portscan/portclippy. Can you drop them?
CONFLICTS_INSTALL= go-devel CONFLICTS_INSTALL?= go-devel
tobikUnsubmitted
Done
Inline Actions

Overwrites the one from go-devel. Use ?=.

tobik: Overwrites the one from go-devel. Use `?=`.
# Upstream archive contains files with UTF-8 names # Upstream archive contains files with UTF-8 names
EXTRACT_CMD= ${SETENV} LC_ALL=en_US.UTF-8 ${TAR} EXTRACT_CMD= ${SETENV} LC_ALL=en_US.UTF-8 ${TAR}
.ifndef MASTERDIR
WRKSRC= ${WRKDIR}/go WRKSRC= ${WRKDIR}/go
.endif
OPTIONS_DEFINE_i386= GO387 OPTIONS_DEFINE_i386= GO387
GO387_DESC= Do not generate code with SSE2 (for old x86 CPU) GO387_DESC= Do not generate code with SSE2 (for old x86 CPU)
GO387_VARS= GO386=387 GO387_VARS= GO386=387
BINARIES= go gofmt BINARIES= go gofmt
▲ Show 20 Lines • Show All 73 Lines • Show Last 20 Lines
View Options

sys/fs/msdosfs/denode.h

# Created by: Devon H. O'Dell <devon.odell@gmail.com> # Created by: Devon H. O'Dell <devon.odell@gmail.com>
# $FreeBSD$ # $FreeBSD$
PORTNAME= go PORTNAME= go
PORTVERSION= 1.14.2 PORTVERSION?= 1.14.2
PORTEPOCH= 1 PORTREVISION?= 0
PORTEPOCH?= 1
CATEGORIES= lang CATEGORIES= lang
MASTER_SITES= https://golang.org/dl/ \ MASTER_SITES?= https://golang.org/dl/ \
https://github.com/dmgk/go-bootstrap/releases/download/${BOOTSTRAP_TAG}/:bootstrap \ https://github.com/dmgk/go-bootstrap/releases/download/${BOOTSTRAP_TAG}/:bootstrap \
LOCAL/dmgk:bootstrap LOCAL/dmgk:bootstrap
DISTFILES= go${PORTVERSION}.src.tar.gz \ DISTFILES?= go${PORTVERSION}.src.tar.gz \
go-${OPSYS:tl}-${GOARCH_${ARCH}}${GOARM_${ARCH}}-${BOOTSTRAP_TAG}.tar.xz:bootstrap go-${OPSYS:tl}-${GOARCH_${ARCH}}${GOARM_${ARCH}}-${BOOTSTRAP_TAG}.tar.xz:bootstrap
MAINTAINER= dmgk@FreeBSD.org MAINTAINER= dmgk@FreeBSD.org
COMMENT= Go programming language COMMENT?= Go programming language
tobikUnsubmitted
Done
Inline Actions

Oh, COMMENT also needs ?=.

tobik: Oh, COMMENT also needs `?=`.
dmgkAuthorUnsubmitted
Done
Inline Actions

Thanks for catching these.

dmgk: Thanks for catching these.
LICENSE= BSD3CLAUSE LICENSE= BSD3CLAUSE
LICENSE_FILE= ${WRKSRC}/LICENSE LICENSE_FILE= ${WRKSRC}/LICENSE
.ifdef QEMU_EMULATING .ifdef QEMU_EMULATING
IGNORE= fails to build with qemu-user-static IGNORE= fails to build with qemu-user-static
.endif .endif
ONLY_FOR_ARCHS= aarch64 amd64 armv6 armv7 i386 ONLY_FOR_ARCHS= aarch64 amd64 armv6 armv7 i386
RUN_DEPENDS= ${RUN_DEPENDS_${ARCH}} RUN_DEPENDS= ${RUN_DEPENDS_${ARCH}}
# ld.bfd from devel/binutils is needed for working cgo on aarch64 # ld.bfd from devel/binutils is needed for working cgo on aarch64
RUN_DEPENDS_aarch64= binutils>0:devel/binutils RUN_DEPENDS_aarch64= binutils>0:devel/binutils
TEST_DEPENDS= ${TEST_DEPENDS_${ARCH}} TEST_DEPENDS= ${TEST_DEPENDS_${ARCH}}
TEST_DEPENDS_aarch64= binutils>0:devel/binutils TEST_DEPENDS_aarch64= binutils>0:devel/binutils
USES= shebangfix USES= shebangfix
SHEBANG_FILES= misc/wasm/go_js_wasm_exec \ SHEBANG_FILES= misc/wasm/go_js_wasm_exec \
src/net/http/cgi/testdata/test.cgi src/net/http/cgi/testdata/test.cgi
SHEBANG_GLOB= *.bash *.pl *.sh SHEBANG_GLOB= *.bash *.pl *.sh
sh_OLD_CMD= /bin/bash "/usr/bin/env bash"
sh_CMD= ${SH}
tobikUnsubmitted
Done
Inline Actions

Unrelated to this review, but these are now flagged by portscan/portclippy. Can you drop them? Without setting SHEBANG_LANG=sh they are unused.

tobik: Unrelated to this review, but these are now flagged by portscan/portclippy. Can you drop them?
CONFLICTS_INSTALL= go-devel CONFLICTS_INSTALL?= go-devel
tobikUnsubmitted
Done
Inline Actions

Overwrites the one from go-devel. Use ?=.

tobik: Overwrites the one from go-devel. Use `?=`.
# Upstream archive contains files with UTF-8 names # Upstream archive contains files with UTF-8 names
EXTRACT_CMD= ${SETENV} LC_ALL=en_US.UTF-8 ${TAR} EXTRACT_CMD= ${SETENV} LC_ALL=en_US.UTF-8 ${TAR}
.ifndef MASTERDIR
WRKSRC= ${WRKDIR}/go WRKSRC= ${WRKDIR}/go
.endif
OPTIONS_DEFINE_i386= GO387 OPTIONS_DEFINE_i386= GO387
GO387_DESC= Do not generate code with SSE2 (for old x86 CPU) GO387_DESC= Do not generate code with SSE2 (for old x86 CPU)
GO387_VARS= GO386=387 GO387_VARS= GO386=387
BINARIES= go gofmt BINARIES= go gofmt
▲ Show 20 Lines • Show All 73 Lines • Show Last 20 Lines
View Options

sys/fs/msdosfs/msdosfs_lookup.c

# Created by: Devon H. O'Dell <devon.odell@gmail.com> # Created by: Devon H. O'Dell <devon.odell@gmail.com>
# $FreeBSD$ # $FreeBSD$
PORTNAME= go PORTNAME= go
PORTVERSION= 1.14.2 PORTVERSION?= 1.14.2
PORTEPOCH= 1 PORTREVISION?= 0
PORTEPOCH?= 1
CATEGORIES= lang CATEGORIES= lang
MASTER_SITES= https://golang.org/dl/ \ MASTER_SITES?= https://golang.org/dl/ \
https://github.com/dmgk/go-bootstrap/releases/download/${BOOTSTRAP_TAG}/:bootstrap \ https://github.com/dmgk/go-bootstrap/releases/download/${BOOTSTRAP_TAG}/:bootstrap \
LOCAL/dmgk:bootstrap LOCAL/dmgk:bootstrap
DISTFILES= go${PORTVERSION}.src.tar.gz \ DISTFILES?= go${PORTVERSION}.src.tar.gz \
go-${OPSYS:tl}-${GOARCH_${ARCH}}${GOARM_${ARCH}}-${BOOTSTRAP_TAG}.tar.xz:bootstrap go-${OPSYS:tl}-${GOARCH_${ARCH}}${GOARM_${ARCH}}-${BOOTSTRAP_TAG}.tar.xz:bootstrap
MAINTAINER= dmgk@FreeBSD.org MAINTAINER= dmgk@FreeBSD.org
COMMENT= Go programming language COMMENT?= Go programming language
tobikUnsubmitted
Done
Inline Actions

Oh, COMMENT also needs ?=.

tobik: Oh, COMMENT also needs `?=`.
dmgkAuthorUnsubmitted
Done
Inline Actions

Thanks for catching these.

dmgk: Thanks for catching these.
LICENSE= BSD3CLAUSE LICENSE= BSD3CLAUSE
LICENSE_FILE= ${WRKSRC}/LICENSE LICENSE_FILE= ${WRKSRC}/LICENSE
.ifdef QEMU_EMULATING .ifdef QEMU_EMULATING
IGNORE= fails to build with qemu-user-static IGNORE= fails to build with qemu-user-static
.endif .endif
ONLY_FOR_ARCHS= aarch64 amd64 armv6 armv7 i386 ONLY_FOR_ARCHS= aarch64 amd64 armv6 armv7 i386
RUN_DEPENDS= ${RUN_DEPENDS_${ARCH}} RUN_DEPENDS= ${RUN_DEPENDS_${ARCH}}
# ld.bfd from devel/binutils is needed for working cgo on aarch64 # ld.bfd from devel/binutils is needed for working cgo on aarch64
RUN_DEPENDS_aarch64= binutils>0:devel/binutils RUN_DEPENDS_aarch64= binutils>0:devel/binutils
TEST_DEPENDS= ${TEST_DEPENDS_${ARCH}} TEST_DEPENDS= ${TEST_DEPENDS_${ARCH}}
TEST_DEPENDS_aarch64= binutils>0:devel/binutils TEST_DEPENDS_aarch64= binutils>0:devel/binutils
USES= shebangfix USES= shebangfix
SHEBANG_FILES= misc/wasm/go_js_wasm_exec \ SHEBANG_FILES= misc/wasm/go_js_wasm_exec \
src/net/http/cgi/testdata/test.cgi src/net/http/cgi/testdata/test.cgi
SHEBANG_GLOB= *.bash *.pl *.sh SHEBANG_GLOB= *.bash *.pl *.sh
sh_OLD_CMD= /bin/bash "/usr/bin/env bash"
sh_CMD= ${SH}
tobikUnsubmitted
Done
Inline Actions

Unrelated to this review, but these are now flagged by portscan/portclippy. Can you drop them? Without setting SHEBANG_LANG=sh they are unused.

tobik: Unrelated to this review, but these are now flagged by portscan/portclippy. Can you drop them?
CONFLICTS_INSTALL= go-devel CONFLICTS_INSTALL?= go-devel
tobikUnsubmitted
Done
Inline Actions

Overwrites the one from go-devel. Use ?=.

tobik: Overwrites the one from go-devel. Use `?=`.
# Upstream archive contains files with UTF-8 names # Upstream archive contains files with UTF-8 names
EXTRACT_CMD= ${SETENV} LC_ALL=en_US.UTF-8 ${TAR} EXTRACT_CMD= ${SETENV} LC_ALL=en_US.UTF-8 ${TAR}
.ifndef MASTERDIR
WRKSRC= ${WRKDIR}/go WRKSRC= ${WRKDIR}/go
.endif
OPTIONS_DEFINE_i386= GO387 OPTIONS_DEFINE_i386= GO387
GO387_DESC= Do not generate code with SSE2 (for old x86 CPU) GO387_DESC= Do not generate code with SSE2 (for old x86 CPU)
GO387_VARS= GO386=387 GO387_VARS= GO386=387
BINARIES= go gofmt BINARIES= go gofmt
▲ Show 20 Lines • Show All 73 Lines • Show Last 20 Lines
View Options

sys/fs/msdosfs/msdosfs_vfsops.c

# Created by: Devon H. O'Dell <devon.odell@gmail.com> # Created by: Devon H. O'Dell <devon.odell@gmail.com>
# $FreeBSD$ # $FreeBSD$
PORTNAME= go PORTNAME= go
PORTVERSION= 1.14.2 PORTVERSION?= 1.14.2
PORTEPOCH= 1 PORTREVISION?= 0
PORTEPOCH?= 1
CATEGORIES= lang CATEGORIES= lang
MASTER_SITES= https://golang.org/dl/ \ MASTER_SITES?= https://golang.org/dl/ \
https://github.com/dmgk/go-bootstrap/releases/download/${BOOTSTRAP_TAG}/:bootstrap \ https://github.com/dmgk/go-bootstrap/releases/download/${BOOTSTRAP_TAG}/:bootstrap \
LOCAL/dmgk:bootstrap LOCAL/dmgk:bootstrap
DISTFILES= go${PORTVERSION}.src.tar.gz \ DISTFILES?= go${PORTVERSION}.src.tar.gz \
go-${OPSYS:tl}-${GOARCH_${ARCH}}${GOARM_${ARCH}}-${BOOTSTRAP_TAG}.tar.xz:bootstrap go-${OPSYS:tl}-${GOARCH_${ARCH}}${GOARM_${ARCH}}-${BOOTSTRAP_TAG}.tar.xz:bootstrap
MAINTAINER= dmgk@FreeBSD.org MAINTAINER= dmgk@FreeBSD.org
COMMENT= Go programming language COMMENT?= Go programming language
tobikUnsubmitted
Done
Inline Actions

Oh, COMMENT also needs ?=.

tobik: Oh, COMMENT also needs `?=`.
dmgkAuthorUnsubmitted
Done
Inline Actions

Thanks for catching these.

dmgk: Thanks for catching these.
LICENSE= BSD3CLAUSE LICENSE= BSD3CLAUSE
LICENSE_FILE= ${WRKSRC}/LICENSE LICENSE_FILE= ${WRKSRC}/LICENSE
.ifdef QEMU_EMULATING .ifdef QEMU_EMULATING
IGNORE= fails to build with qemu-user-static IGNORE= fails to build with qemu-user-static
.endif .endif
ONLY_FOR_ARCHS= aarch64 amd64 armv6 armv7 i386 ONLY_FOR_ARCHS= aarch64 amd64 armv6 armv7 i386
RUN_DEPENDS= ${RUN_DEPENDS_${ARCH}} RUN_DEPENDS= ${RUN_DEPENDS_${ARCH}}
# ld.bfd from devel/binutils is needed for working cgo on aarch64 # ld.bfd from devel/binutils is needed for working cgo on aarch64
RUN_DEPENDS_aarch64= binutils>0:devel/binutils RUN_DEPENDS_aarch64= binutils>0:devel/binutils
TEST_DEPENDS= ${TEST_DEPENDS_${ARCH}} TEST_DEPENDS= ${TEST_DEPENDS_${ARCH}}
TEST_DEPENDS_aarch64= binutils>0:devel/binutils TEST_DEPENDS_aarch64= binutils>0:devel/binutils
USES= shebangfix USES= shebangfix
SHEBANG_FILES= misc/wasm/go_js_wasm_exec \ SHEBANG_FILES= misc/wasm/go_js_wasm_exec \
src/net/http/cgi/testdata/test.cgi src/net/http/cgi/testdata/test.cgi
SHEBANG_GLOB= *.bash *.pl *.sh SHEBANG_GLOB= *.bash *.pl *.sh
sh_OLD_CMD= /bin/bash "/usr/bin/env bash"
sh_CMD= ${SH}
tobikUnsubmitted
Done
Inline Actions

Unrelated to this review, but these are now flagged by portscan/portclippy. Can you drop them? Without setting SHEBANG_LANG=sh they are unused.

tobik: Unrelated to this review, but these are now flagged by portscan/portclippy. Can you drop them?
CONFLICTS_INSTALL= go-devel CONFLICTS_INSTALL?= go-devel
tobikUnsubmitted
Done
Inline Actions

Overwrites the one from go-devel. Use ?=.

tobik: Overwrites the one from go-devel. Use `?=`.
# Upstream archive contains files with UTF-8 names # Upstream archive contains files with UTF-8 names
EXTRACT_CMD= ${SETENV} LC_ALL=en_US.UTF-8 ${TAR} EXTRACT_CMD= ${SETENV} LC_ALL=en_US.UTF-8 ${TAR}
.ifndef MASTERDIR
WRKSRC= ${WRKDIR}/go WRKSRC= ${WRKDIR}/go
.endif
OPTIONS_DEFINE_i386= GO387 OPTIONS_DEFINE_i386= GO387
GO387_DESC= Do not generate code with SSE2 (for old x86 CPU) GO387_DESC= Do not generate code with SSE2 (for old x86 CPU)
GO387_VARS= GO386=387 GO387_VARS= GO386=387
BINARIES= go gofmt BINARIES= go gofmt
▲ Show 20 Lines • Show All 73 Lines • Show Last 20 Lines