Page MenuHomeFreeBSD
Differential D7913

head(1): Capsicumify
AbandonedPublic
Actions

Authored by cem on Sep 18 2016, 1:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 4, 2:19 AM
Unknown Object (File)
Sun, Oct 4, 12:31 AM
Unknown Object (File)
Sat, Oct 3, 11:27 PM
Unknown Object (File)
Sat, Oct 3, 11:12 PM
Unknown Object (File)
Sat, Sep 26, 8:45 PM
Unknown Object (File)
Sun, Sep 20, 1:05 AM
Unknown Object (File)
Sat, Sep 19, 3:08 PM
Unknown Object (File)
Fri, Sep 18, 7:16 AM
View All Files
Subscribers
imp

Details

Reviewers
emaste
allanjude
oshogbo
Summary

Capsicumify head(1) by restricting it to a readonly view of the
filesystem. This is both easy to do and impacts performance minimally.

Access to the filesystem could be restricted further, but requires more
elaborate implementation and may suffer from performance trade-off.
This is left as future work.

Test Plan
  • Tested 'head foobar.txt'
  • Tested 'head < foobar.txt'
  • Tested 'head -c10 < foobar.txt'

Diff Detail

Event Timeline

cem updated this revision to Diff 20409.Sep 18 2016, 1:03 AM
cem retitled this revision from to head(1): Capsicumify last input file.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added reviewers: emaste, allanjude, oshogbo.
Herald added a subscriber: imp. · View Herald TranscriptSep 18 2016, 1:03 AM
emaste edited edge metadata.Oct 19 2016, 9:39 PM

I think the approach is fine - we'll revisit all of these "capsicumify on last file" cases once a file service is available. Can you update with capsicum_helpers though?

cem updated this revision to Diff 21563.Oct 20 2016, 9:51 PM
cem edited edge metadata.

Update to use helpers.

cem updated this revision to Diff 22788.Dec 9 2016, 9:20 PM

Use https://reviews.freebsd.org/D8743 to enter sandbox over all inputs.

It feels like something like 'abspath' should be available in a library for
similarly-sandboxed applications.

cem retitled this revision from head(1): Capsicumify last input file to head(1): Capsicumify.Dec 9 2016, 9:24 PM
cem updated this object.
cem abandoned this revision.Dec 23 2016, 12:00 AM

Revision Contents
Changeset List

PathSize
usr.bin/
head/
48 lines

Diff 20409

View Options

usr.bin/head/head.c

Loading...