Initial support for Allwinner A64 SoC.
What's working:
- MMC
- GPIO / pinctrl
- Clock controller
- NMI intc
- RSB
- AXP803 PMIC
- Ethernet
- MMC
- USB host controllers
Details
Details
- Reviewers
- None
- Group Reviewers
ARM arm64 - Commits
- rS305134: Add Allwinner A64 (sun50i) and Pine64 dts files.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| sys/arm/allwinner/a10_mmc.c | ||
|---|---|---|
| 200 ↗ | (On Diff #18246) | Can you make it #else /* __aarch64__ */ so it's documented what the else case if for. |
| sys/arm/allwinner/aw_rtc.c | ||
| 67 ↗ | (On Diff #18246) | #else /* __arm__ */ |
| sys/arm/allwinner/aw_usbphy.c | ||
| 44 ↗ | (On Diff #18246) | Why is this needed? |
| 183–184 ↗ | (On Diff #18246) | Use %jd and cast phy to an intmax_t |
| sys/arm/allwinner/clk/aw_gate.c | ||
| 140 ↗ | (On Diff #18246) | Why not just return? There's no tear down in the failure case that a goto would simplify. |
| sys/arm64/conf/GENERIC | ||
| 180–182 ↗ | (On Diff #18246) | These shouldn't be added to GENERIC |
| sys/conf/files.arm64 | ||
| 95 ↗ | (On Diff #18246) | This is already in sys/conf/files. |
| sys/arm/allwinner/aw_rtc.c | ||
|---|---|---|
| 68 ↗ | (On Diff #18246) | Also maybe update the RTC driver to have the year min/max stuff into softc so we don't rely on allwinner_soc_family would be better. |
| sys/arm/allwinner/a10_mmc.c | ||
|---|---|---|
| 262 ↗ | (On Diff #18246) | Agreed |
| 323 ↗ | (On Diff #18246) | Agreed |
| sys/arm/allwinner/a64/files.a64 | ||
| 1 ↗ | (On Diff #18246) | I left it here because I thought we might want to support sun50i in the 32-bit ALLWINNER kernel some day. It doesn't matter to me if files.a64 stays or goes but I think sys/arm is the right place for these files. |
| sys/arm/allwinner/aw_rtc.c | ||
| 68 ↗ | (On Diff #18246) | I can remove the dependency on allwinner_soc_family easily but I think refactoring the driver is best left for a separate commit. |
Comment Actions
I think the following files can just be committed:
a10_ehci.c
a10_gpio.c
a10_mmc.c
a64_padconf.c
a64_r_padconf.c
aw_ccu.c
aw_nmi.c
aw_rsb.c
aw_usbphy.c
options.arm64
| sys/arm/allwinner/clk/aw_gate.c | ||
|---|---|---|
| 195 ↗ | (On Diff #18253) | Can you use ofw_bus_is_compatible here? |
Comment Actions
I think most of the .c and .h files are ready, other than if_awg*. I'm undecided on how to handle dts files for arm64 so hold off on adding them for now.
| sys/conf/files.arm64 | ||
|---|---|---|
| 14–37 ↗ | (On Diff #19600) | You should only use soc_allwinner_a64 for SoC specific attachments. For these you should create a new device name. |
Comment Actions
Can you talk more about this? We have a bit of a mess at the moment in arm land that's closely related to the u-boot mess that we have that I've started to clean up.
Comment Actions
Support both USB host controllers on A64. The first host controller shares a PHY with the OTG controller, so we need to configure the PHY appropriately. Now both USB ports work on Pine64.
Comment Actions
Use the A64 watchdog to reset the system; the psci reboot method doesn't seem to work.
Comment Actions
Sync with head
| sys/arm/allwinner/aw_usbphy.c | ||
|---|---|---|
| 93 ↗ | (On Diff #19840) | Not all usbphy nodes have 3 resources, this needs to be modified to support other SoCs. |