Allwinner A64 support

[jmcneill]

Summary

Initial support for Allwinner A64 SoC.

What's working:

• MMC
• GPIO / pinctrl
• Clock controller
• NMI intc
• RSB
• AXP803 PMIC
• Ethernet
• MMC
• USB host controllers

[andrew]

sys/arm/allwinner/a10_mmc.c

200 ↗

(On Diff #18246)

Can you make it #else /* __aarch64__ */ so it's documented what the else case if for.

sys/arm/allwinner/aw_rtc.c

67

#else /* __arm__ */

sys/arm/allwinner/aw_usbphy.c

44 ↗

(On Diff #18246)

Why is this needed?

183–184 ↗

(On Diff #18246)

Use %jd and cast phy to an intmax_t

sys/arm/allwinner/clk/aw_gate.c

140

Why not just return? There's no tear down in the failure case that a goto would simplify.

sys/arm64/conf/GENERIC

180–182

These shouldn't be added to GENERIC

sys/conf/files.arm64

95

This is already in sys/conf/files.

[manu]

sys/arm/allwinner/a10_mmc.c

262 ↗

(On Diff #18246)

Maybe it would be better in a separate commit ?

323 ↗

(On Diff #18246)

Same thing for the DMA align

sys/arm/allwinner/a64/files.a64

1 ↗

(On Diff #18246)

Is this file used ?
Also maybe it need to go into sys/arm64 instead ?

[manu]

sys/arm/allwinner/aw_rtc.c

65

Also maybe update the RTC driver to have the year min/max stuff into softc so we don't rely on allwinner_soc_family would be better.

[jmcneill]

sys/arm/allwinner/a10_mmc.c

262 ↗

(On Diff #18246)

Agreed

323 ↗

(On Diff #18246)

Agreed

sys/arm/allwinner/a64/files.a64

1 ↗

(On Diff #18246)

I left it here because I thought we might want to support sun50i in the 32-bit ALLWINNER kernel some day. It doesn't matter to me if files.a64 stays or goes but I think sys/arm is the right place for these files.

sys/arm/allwinner/aw_rtc.c

65

I can remove the dependency on allwinner_soc_family easily but I think refactoring the driver is best left for a separate commit.

[jmcneill]

Changes based on feedback from andrew and manu.

[jmcneill]

Update for extres API changes in r302528

[andrew]

I think the following files can just be committed:

a10_ehci.c
a10_gpio.c
a10_mmc.c
a64_padconf.c
a64_r_padconf.c
aw_ccu.c
aw_nmi.c
aw_rsb.c
aw_usbphy.c
options.arm64

sys/arm/allwinner/clk/aw_gate.c

195–199

Can you use ofw_bus_is_compatible here?

[jmcneill]

Sync with head, some changes from the original diff have been committed.

[jmcneill]

fdt_is_compatible -> ofw_bus_is_compatible

[andrew]

sys/arm/allwinner/clk/aw_gate.c

47

Is this needed?

sys/arm/allwinner/if_awg.c

82

What is the busdma issue?

sys/arm/allwinner/if_awgreg.h

181

What is the issue?

[jmcneill]

Sync with head

[manu]

sys/boot/efi/loader/main.c

414 ↗

(On Diff #19600)

This shouldn't be commited with a64 changes.

sys/boot/fdt/dts/arm/a64.dtsi

128

This shouldn't be needed now.

[andrew]

I think most of the .c and .h files are ready, other than if_awg*. I'm undecided on how to handle dts files for arm64 so hold off on adding them for now.

sys/conf/files.arm64

2–25

You should only use soc_allwinner_a64 for SoC specific attachments. For these you should create a new device name.

[imp]

In D7169#158479, @andrew wrote:

I'm undecided on how to handle dts files for arm64 so hold off on adding them for now.

Can you talk more about this? We have a bit of a mess at the moment in arm land that's closely related to the u-boot mess that we have that I've started to clean up.

[jmcneill]

Fixes based on feedback

[jmcneill]

Sync with head, sort devices in GENERIC into device type sections.

[jmcneill]

Sync with head. Only sun50i/a64 and Pine64 .dts files remain.

[jmcneill]

Add support for USB-EHCI0/USB-OHCI0 (bottom USB port on Pine64).

[jmcneill]

Support both USB host controllers on A64. The first host controller shares a PHY with the OTG controller, so we need to configure the PHY appropriately. Now both USB ports work on Pine64.

[jmcneill]

Use the A64 watchdog to reset the system; the psci reboot method doesn't seem to work.

[jmcneill]

Sync with head

sys/arm/allwinner/aw_usbphy.c

93 ↗

(On Diff #19840)

Not all usbphy nodes have 3 resources, this needs to be modified to support other SoCs.

[jmcneill]

Support between 2 and 4 USB PHY resources.

[jmcneill]

Sync with head. The only changes remaining are the new dts files.

[jmcneill]

Move dts files to boot/fdt/dts/arm64

[jmcneill]

add Makefile for boot/fdt/dts/arm64