bspatch: apply style(9)
ClosedPublic
Actions

Authored by emaste on Aug 23 2016, 12:36 PM.

Details

Reviewers

allanjude
cperciva
oshogbo

Commits

rS304691: bspatch: apply style(9)

Summary

Make style changes now in order to reduce noise in diffs for future capsicum changes (D7358 or D7603).

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 19580.Aug 23 2016, 12:36 PM

emaste retitled this revision from to bspatch: apply style(9).

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: allanjude, cperciva, oshogbo.

emaste added inline comments.

usr.bin/bsdiff/bspatch/bspatch.c
148–163	this change (and a similar one for newfd) is not specifically a style(9) change but is a small refactoring also to reduce later capsicum changes

Thank you for doing this.

usr.bin/bsdiff/bspatch/bspatch.c
117–121	space in the wrong position

fix typo spotted by @allanjude
remove unnecessary brackets

oshogbo added inline comments.Aug 23 2016, 5:14 PM

usr.bin/bsdiff/bspatch/bspatch.c
36–37	Maybe: #include <bzlib.h> #include <err.h> #include <fcntl.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <unistd.h>
58	return (y);
70–71	I know that is not direct connected by maybe: FILE f, cpf, dpf, epf; BZFILE cpfbz2, dpfbz2, *epfbz2;
227	return (0);

tweaks suggested by @oshogbo

On IRC @cperciva said no objection

oshogbo accepted this revision.Aug 23 2016, 5:32 PM

oshogbo edited edge metadata.

This revision is now accepted and ready to land.Aug 23 2016, 5:32 PM

Closed by commit rS304691: bspatch: apply style(9) (authored by emaste). · Explain WhyAug 23 2016, 5:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.bin/

bsdiff/

bspatch/

bspatch.c

112 lines

Diff 19590

View Options

usr.bin/bsdiff/bspatch/bspatch.c

bspatch: apply style(9)ClosedPublicActions