Page MenuHomeFreeBSD

bspatch: apply style(9)
ClosedPublic

Authored by emaste on Aug 23 2016, 12:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 13, 10:30 PM
Unknown Object (File)
Wed, Mar 13, 10:28 PM
Unknown Object (File)
Wed, Mar 13, 10:27 PM
Unknown Object (File)
Wed, Mar 13, 10:27 PM
Unknown Object (File)
Wed, Mar 13, 10:27 PM
Unknown Object (File)
Sun, Mar 10, 3:58 PM
Unknown Object (File)
Fri, Mar 1, 9:47 PM
Unknown Object (File)
Feb 23 2024, 12:28 PM
Subscribers
None

Details

Summary

Make style changes now in order to reduce noise in diffs for future capsicum changes (D7358 or D7603).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste retitled this revision from to bspatch: apply style(9).
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: allanjude, cperciva, oshogbo.
emaste added inline comments.
usr.bin/bsdiff/bspatch/bspatch.c
148–151 ↗(On Diff #19580)

this change (and a similar one for newfd) is not specifically a style(9) change but is a small refactoring also to reduce later capsicum changes

Thank you for doing this.

usr.bin/bsdiff/bspatch/bspatch.c
117 ↗(On Diff #19580)

space in the wrong position

emaste edited edge metadata.
  • fix typo spotted by @allanjude
  • remove unnecessary brackets
usr.bin/bsdiff/bspatch/bspatch.c
36 ↗(On Diff #19587)

Maybe:

#include <bzlib.h>
#include <err.h>
#include <fcntl.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>

58 ↗(On Diff #19587)

return (y);

71 ↗(On Diff #19587)

I know that is not direct connected by maybe:

FILE *f, *cpf, *dpf, *epf;
BZFILE *cpfbz2, *dpfbz2, *epfbz2;

227 ↗(On Diff #19587)

return (0);

oshogbo edited edge metadata.
This revision is now accepted and ready to land.Aug 23 2016, 5:32 PM
This revision was automatically updated to reflect the committed changes.