Page MenuHomeFreeBSD

bspatch: apply style(9)
ClosedPublic

Authored by emaste on Aug 23 2016, 12:36 PM.
Tags
None
Referenced Files
F68549691: D7610.diff
Sat, Sep 30, 4:41 PM
Unknown Object (File)
Mon, Sep 25, 7:12 PM
Unknown Object (File)
Fri, Sep 15, 12:18 AM
Unknown Object (File)
Thu, Sep 7, 1:19 AM
Unknown Object (File)
Tue, Sep 5, 3:52 AM
Unknown Object (File)
Aug 10 2023, 7:17 AM
Unknown Object (File)
Aug 8 2023, 3:01 AM
Unknown Object (File)
Jul 25 2023, 12:04 AM
Subscribers
None

Details

Summary

Make style changes now in order to reduce noise in diffs for future capsicum changes (D7358 or D7603).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste retitled this revision from to bspatch: apply style(9).
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: allanjude, cperciva, oshogbo.
emaste added inline comments.
usr.bin/bsdiff/bspatch/bspatch.c
148–151

this change (and a similar one for newfd) is not specifically a style(9) change but is a small refactoring also to reduce later capsicum changes

Thank you for doing this.

usr.bin/bsdiff/bspatch/bspatch.c
117

space in the wrong position

emaste edited edge metadata.
  • fix typo spotted by @allanjude
  • remove unnecessary brackets
usr.bin/bsdiff/bspatch/bspatch.c
36

Maybe:

#include <bzlib.h>
#include <err.h>
#include <fcntl.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>

58

return (y);

71

I know that is not direct connected by maybe:

FILE *f, *cpf, *dpf, *epf;
BZFILE *cpfbz2, *dpfbz2, *epfbz2;

227

return (0);

oshogbo edited edge metadata.
This revision is now accepted and ready to land.Aug 23 2016, 5:32 PM
This revision was automatically updated to reflect the committed changes.