asmc: Use c99 initializers with for-loop counters to improve scoping
ClosedPublic
Actions

Authored by seuros on Sat, Nov 7, 5:04 PM.

Project Tags

None

Referenced Files

	F177556613: D61301.1794712771.diff
	Sat, Nov 14, 3:19 AM

	F177552092: D61301.1794698113.diff
	Fri, Nov 13, 11:15 PM

	F177532964: D61301.1794648690.diff
	Fri, Nov 13, 9:31 AM

	F177528774: D61301.1794636155.diff
	Fri, Nov 13, 6:02 AM

Subscribers

imp

Details

Reviewers

ngie
imp

Commits

rGa3468ea7bd7a: asmc: Use c99 initializers with for-loop counters to improve scoping

Summary

declared loop indices in the for statement
Index types are unchanged.

No functional change.

MFC After: 1 Week
Approved-by: ngie (co-mentor)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 78825
Build 75708: arc lint + arc unit

Event Timeline

seuros created this revision.Sat, Nov 7, 5:04 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Nov 7, 5:04 PM

seuros requested review of this revision.Sat, Nov 7, 5:04 PM

Harbormaster completed remote builds in B78825: Diff 191835.Sat, Nov 7, 5:04 PM

seuros added a parent revision: D61300: asmc: split the sysctl layer into asmcsysctl.c.Sat, Nov 7, 5:34 PM

seuros added a child revision: D61302: asmc: Fix style(9) issues.

“Use c99 initializers with for-loop counters to improve scoping”?

seuros retitled this revision from asmc: declare loop indices in the for statement to asmc: Use c99 initializers with for-loop counters to improve scoping.Sun, Nov 8, 6:38 AM

seuros edited the summary of this revision. (Show Details)

imp accepted this revision.Sun, Nov 8, 6:42 AM

This revision is now accepted and ready to land.Sun, Nov 8, 6:42 AM

rename

This revision now requires review to proceed.Sun, Nov 8, 9:40 AM

Harbormaster completed remote builds in B78854: Diff 191895.Sun, Nov 8, 9:40 AM

Approved-by: ngie (co-mentor)

This revision is now accepted and ready to land.Mon, Nov 9, 3:13 AM

seuros edited the summary of this revision. (Show Details)Mon, Nov 9, 5:00 PM

Closed by commit rGa3468ea7bd7a: asmc: Use c99 initializers with for-loop counters to improve scoping. · Explain WhyMon, Nov 9, 6:37 PM

This revision was automatically updated to reflect the committed changes.

seuros added a commit: rGa3468ea7bd7a: asmc: Use c99 initializers with for-loop counters to improve scoping.

Revision Contents
Changeset List

Path

Size

sys/

dev/

asmc/

11 lines

3 lines

3 lines

10 lines

8 lines

Diff 191835

View Options

sys/dev/asmc/asmc.c

View Options

sys/dev/asmc/asmcdebug.c

View Options

sys/dev/asmc/asmcmmio.c

View Options

sys/dev/asmc/asmcpio.c

View Options

asmc: Use c99 initializers with for-loop counters to improve scopingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 191835

sys/dev/asmc/asmc.c

sys/dev/asmc/asmcdebug.c

sys/dev/asmc/asmcmmio.c

sys/dev/asmc/asmcpio.c

sys/dev/asmc/asmcsysctl.c

asmc: Use c99 initializers with for-loop counters to improve scoping
ClosedPublic
Actions

Revision Contents
Changeset List