Differential D61029

sdiotool: Use (void) for functions taking no arguments
ClosedPublic
Actions

Authored by manu on Fri, Oct 30, 8:09 AM.

Project Tags

None

Referenced Files

None

Subscribers

imp

Details

Reviewers

bz
oh

Group Reviewers

arm64

Commits

rGe5b68a6a00e6: sdiotool: Use (void) for functions taking no arguments

Summary

Use (void) instead of an empty parameter list, as required by style(9), and let the compiler diagnose calls with unexpected arguments.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 78559
Build 75442: arc lint + arc unit

Event Timeline

manu created this revision.Fri, Oct 30, 8:09 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 30, 8:09 AM

manu requested review of this revision.Fri, Oct 30, 8:09 AM

Harbormaster completed remote builds in B78559: Diff 190959.Fri, Oct 30, 8:09 AM

manu added a parent revision: D61028: sdiotool: Remove the unused -f option.Fri, Oct 30, 8:09 AM

manu added a child revision: D61030: sdiotool: Do not treat an unknown chip ID as fatal.

manu added reviewers: arm64, bz.Fri, Oct 30, 8:10 AM

oh accepted this revision.Fri, Oct 30, 10:15 AM

This revision is now accepted and ready to land.Fri, Oct 30, 10:15 AM

Closed by commit rGe5b68a6a00e6: sdiotool: Use (void) for functions taking no arguments. · Explain WhyThu, Nov 5, 2:53 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rGe5b68a6a00e6: sdiotool: Use (void) for functions taking no arguments.

Revision Contents
Changeset List

Path

Size

usr.bin/

sdiotool/

sdiotool.c

4 lines

Diff 190959

View Options

usr.bin/sdiotool/sdiotool.c

sdiotool: Use (void) for functions taking no argumentsClosedPublicActions