sdiotool: Remove the unused -f option
ClosedPublic
Actions

Authored by manu on Fri, Oct 30, 8:09 AM.

Project Tags

None

Referenced Files

	F177358940: D61028.1794192737.diff
	Sun, Nov 8, 2:52 AM

	F177337199: D61028.1794149481.diff
	Sat, Nov 7, 2:51 PM

Subscribers

imp

Details

Reviewers

bz
oh

Group Reviewers

arm64

Commits

rGc67a07eb2cf8: sdiotool: Remove the unused -f option

Summary

The -f option was parsed but never used. Its argument handling was also broken: getopt(3) binds the argument to the last option letter, so "fu:" made -f take no argument at all. Remove it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Fri, Oct 30, 8:09 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 30, 8:09 AM

manu requested review of this revision.Fri, Oct 30, 8:09 AM

Harbormaster completed remote builds in B78558: Diff 190958.Fri, Oct 30, 8:09 AM

manu added a parent revision: D61027: sdiotool: Use the system bool type.Fri, Oct 30, 8:09 AM

manu added a child revision: D61029: sdiotool: Use (void) for functions taking no arguments.

manu added reviewers: arm64, bz.Fri, Oct 30, 8:10 AM

oh accepted this revision.Fri, Oct 30, 10:26 AM

This revision is now accepted and ready to land.Fri, Oct 30, 10:26 AM

Closed by commit rGc67a07eb2cf8: sdiotool: Remove the unused -f option. · Explain WhyThu, Nov 5, 2:53 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rGc67a07eb2cf8: sdiotool: Remove the unused -f option.

Revision Contents
Changeset List

Path

Size

usr.bin/

sdiotool/

sdiotool.c

6 lines

Diff 191611

View Options

usr.bin/sdiotool/sdiotool.c

sdiotool: Remove the unused -f optionClosedPublicActions