sdiotool: Do not treat an unknown chip ID as fatal
ClosedPublic
Actions

Authored by manu on Fri, Oct 30, 8:09 AM.

Project Tags

None

Referenced Files

	F177241608: D61030.1793988852.diff
	Thu, Nov 5, 6:14 PM

	F177230836: D61030.1793976068.diff
	Thu, Nov 5, 2:41 PM

Subscribers

imp

Details

Reviewers

Group Reviewers

arm64

Commits

rGc502df9eb193: sdiotool: Do not treat an unknown chip ID as fatal

Summary

The tool is useful for probing any SDIO card, not only the BCM4330. Print the chip ID, report a failed backplane read, and only note when the ID is not the expected REPLY_MAGIC instead of exiting.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Fri, Oct 30, 8:09 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 30, 8:09 AM

Harbormaster completed remote builds in B78560: Diff 190960.Fri, Oct 30, 8:09 AM

manu requested review of this revision.Fri, Oct 30, 8:09 AM

manu added a parent revision: D61029: sdiotool: Use (void) for functions taking no arguments.

manu added reviewers: arm64, bz.Fri, Oct 30, 8:10 AM

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Nov 5, 2:53 PM

Closed by commit rGc502df9eb193: sdiotool: Do not treat an unknown chip ID as fatal. · Explain Why

This revision was automatically updated to reflect the committed changes.

manu added a commit: rGc502df9eb193: sdiotool: Do not treat an unknown chip ID as fatal.

Revision Contents
Changeset List

Path

Size

usr.bin/

sdiotool/

sdiotool.c

11 lines

Diff 191614

View Options

usr.bin/sdiotool/sdiotool.c

sdiotool: Do not treat an unknown chip ID as fatalClosedPublicActions