sdiotool: Fix writes being issued as reads
ClosedPublic
Actions

Authored by manu on Fri, Oct 30, 8:09 AM.

Project Tags

None

Referenced Files

	F177546031: D61026.1794678553.diff
	Fri, Nov 13, 5:49 PM

	F177546019: D61026.1794678456.diff
	Fri, Nov 13, 5:47 PM

Subscribers

imp

Details

Reviewers

bz
oh

Group Reviewers

arm64

Commits

rGd61de53d18df: sdiotool: Fix writes being issued as reads

Summary

sdio_write_1() passed 0 as the write flag to sdio_rw_direct(), so every write was performed as a read and the value was never sent to the card. Pass 1 so that the data is actually written.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Fri, Oct 30, 8:09 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 30, 8:09 AM

manu requested review of this revision.Fri, Oct 30, 8:09 AM

Harbormaster completed remote builds in B78556: Diff 190956.Fri, Oct 30, 8:09 AM

manu added a child revision: D61027: sdiotool: Use the system bool type.Fri, Oct 30, 8:09 AM

manu added reviewers: arm64, bz.Fri, Oct 30, 8:11 AM

oh accepted this revision.Fri, Oct 30, 10:34 AM

This revision is now accepted and ready to land.Fri, Oct 30, 10:34 AM

Closed by commit rGd61de53d18df: sdiotool: Fix writes being issued as reads. · Explain WhyThu, Nov 5, 2:52 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rGd61de53d18df: sdiotool: Fix writes being issued as reads.

Revision Contents
Changeset List

Path

Size

usr.bin/

sdiotool/

cam_sdio.c

2 lines

Diff 191610

View Options

usr.bin/sdiotool/cam_sdio.c

sdiotool: Fix writes being issued as readsClosedPublicActions