Differential D7415

tcp/lro: If timestamps mismatch or it's a FIN, force flush.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Aug 4 2016, 8:50 AM.

Tags

None

Referenced Files

	F137106388: D7415.id19031.diff
	Fri, Nov 21, 3:53 AM

	F137106307: D7415.id.diff
	Fri, Nov 21, 3:53 AM

	F137105730: D7415.id19032.diff
	Fri, Nov 21, 3:52 AM

	F137105699: D7415.id19063.diff
	Fri, Nov 21, 3:51 AM

	F137105109: D7415.diff
	Fri, Nov 21, 3:50 AM

	Unknown Object (File)
	Wed, Nov 19, 8:29 AM

	Unknown Object (File)
	Tue, Nov 18, 2:46 PM

	Unknown Object (File)
	Mon, Nov 17, 10:58 AM

Subscribers

freebsd-net-list

Details

Reviewers

gallatin
hiren
• hselasky
np
rrs
glebius
bz

Group Reviewers

Commits

rS303766: tcp/lro: If timestamps mismatch or it's a FIN, force flush.

Summary

This keeps the segments/ACK/FIN delivery order.

Before this patch, it was observed: if A sent FIN immediately after
an ACK, B would deliver FIN first to the TCP stack, then the ACK.
This out-of-order delivery causes one unnecessary ACK sent from B.

Obtained from:  gallatin, rrs

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sepherosa_gmail.com updated this revision to Diff 19031.Aug 4 2016, 8:50 AM

sepherosa_gmail.com retitled this revision from to tcp/lro: If timestamps mismatch or it's a FIN, force flush..

sepherosa_gmail.com updated this object.

sepherosa_gmail.com edited the test plan for this revision. (Show Details)

sepherosa_gmail.com added reviewers: rrs, gallatin, • hselasky, np, glebius.

sepherosa_gmail.com added a subscriber: freebsd-net-list.

Herald added a reviewer: transport. · View Herald TranscriptAug 4 2016, 8:50 AM

sepherosa_gmail.com added reviewers: hiren, bz.Aug 4 2016, 8:54 AM

• hselasky added inline comments.Aug 4 2016, 9:07 AM

sys/netinet/tcp_lro.c
852–860	Should there be added: if (force_flush) return (TCP_LRO_CANNOT); If no match is found in the list?

sepherosa_gmail.com added inline comments.Aug 4 2016, 9:19 AM

sys/netinet/tcp_lro.c
852–860	Ah, yeah, it was in the original patch from rrs, got lost by me :P

Don't create entry for segments cant be further aggregated/delayed. Noticed-by: hps

Herald edited edge metadata. · View Herald TranscriptAug 4 2016, 9:26 AM

Looks good to me.

--HPS

gallatin accepted this revision.Aug 4 2016, 12:20 PM

gallatin edited edge metadata.

Closed by commit rS303766: tcp/lro: If timestamps mismatch or it's a FIN, force flush. (authored by sephe). · Explain WhyAug 5 2016, 9:08 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

36 lines

Diff 19032

sys/netinet/tcp_lro.c

Loading...