Page MenuHomeFreeBSD
Differential D7405

hyperv/storvsc: Enable TRIM support for Win2012R2
ClosedPublic
Actions

Authored by honzhan_microsoft.com on Aug 3 2016, 5:05 AM.
Tags
None
Referenced Files
F157196077: D7405.id19027.diff
Tue, May 19, 5:54 AM
F157192784: D7405.id19027.diff
Tue, May 19, 5:01 AM
F157139392: D7405.diff
Mon, May 18, 5:21 PM
F157128705: D7405.diff
Mon, May 18, 3:33 PM
F157128704: D7405.diff
Mon, May 18, 3:33 PM
F157128686: D7405.diff
Mon, May 18, 3:33 PM
Unknown Object (File)
Mon, May 18, 7:25 AM
Unknown Object (File)
Mon, May 18, 7:01 AM
View All Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
howard0su_gmail.com
decui_microsoft.com
hrs
delphij
sepherosa_gmail.com
royger
Commits
rS303737: hyperv/storvsc: Claim SPC-3 conformance, thus enable UNMAP support
Summary

On win8 and win2012 the inquiry response indicates the device is SPC-2, but in fact it is SPC-3.
This is a host issue and has fixed on win2016. FreeBSD VM has to manually set SCSI version to SPC-3 to support TRIM.

Submitted by: Hongjiang Zhang <honzhan microsoft com>

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

honzhan_microsoft.com updated this revision to Diff 18989.Aug 3 2016, 5:05 AM
honzhan_microsoft.com retitled this revision from to hyperv/storvsc: Enable TRIM support for Win2012R2.
honzhan_microsoft.com updated this object.
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptAug 3 2016, 5:05 AM
honzhan_microsoft.com updated this object.Aug 3 2016, 5:17 AM
honzhan_microsoft.com added reviewers: hrs, sepherosa_gmail.com, decui_microsoft.com, delphij, royger, howard0su_gmail.com.
sepherosa_gmail.com accepted this revision.Aug 3 2016, 5:27 AM
sepherosa_gmail.com edited edge metadata.

Fix the comment. Rest looks fine.

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
2162

UNMAP?

This revision is now accepted and ready to land.Aug 3 2016, 5:27 AM
honzhan_microsoft.com added inline comments.Aug 3 2016, 5:29 AM
sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
2162

yes, UNMAP is the formal command.

honzhan_microsoft.com updated this revision to Diff 18990.Aug 3 2016, 5:35 AM
honzhan_microsoft.com edited edge metadata.
honzhan_microsoft.com removed rS FreeBSD src repository - subversion as the repository for this revision.
This revision now requires review to proceed.Aug 3 2016, 5:35 AM
sepherosa_gmail.com accepted this revision.Aug 3 2016, 5:49 AM
sepherosa_gmail.com edited edge metadata.
This revision is now accepted and ready to land.Aug 3 2016, 5:49 AM
Closed by commit rS303737: hyperv/storvsc: Claim SPC-3 conformance, thus enable UNMAP support (authored by sephe). · Explain WhyAug 4 2016, 5:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
storvsc/
23 lines

Diff 18990

View Options

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c

Loading...