ARM : Keep boot parameters in trampoline code
ClosedPublic
Actions

Authored by soutade_gmail.com on Aug 2 2016, 1:28 PM.

Details

Reviewers

manu
imp

Group Reviewers

ARM

Commits

rS331891: MFC r304488, r304623
rS304488: Keep boot parameters in ARM trampoline code

Summary

Currently boot parameters (r0 - r3) are forgotten in ARM trampoline code. This patch save them at startup and restore them before jumping into kernel _start() routine.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

soutade_gmail.com updated this revision to Diff 18957.Aug 2 2016, 1:28 PM

soutade_gmail.com retitled this revision from to ARM : Keep boot parameters in trampoline code.

soutade_gmail.com updated this object.

soutade_gmail.com edited the test plan for this revision. (Show Details)

soutade_gmail.com added a reviewer: bapt.

soutade_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.

soutade_gmail.com added a project: ARM.

Herald added subscribers: andrew, imp. · View Herald TranscriptAug 2 2016, 1:28 PM

bapt edited reviewers, added: ARM; removed: bapt.Aug 2 2016, 1:42 PM

It looks good, can you regenerate the diff as now it doesn't apply cleany ?
Thanks,

Seems reasonable to me. I added code to do this in the normal kernel, but not in the tramp code because I didn't need it. Not sure your boot environment, but it certainly doesn't hurt anything and may help.

Update diff to current HEAD

In D7395#156870, @imp wrote:

Seems reasonable to me. I added code to do this in the normal kernel, but not in the tramp code because I didn't need it. Not sure your boot environment, but it certainly doesn't hurt anything and may help.

It's a custom bootloader with Linux boot ABI.

manu accepted this revision.Aug 18 2016, 11:10 AM

manu added a reviewer: manu.

This revision is now accepted and ready to land.Aug 18 2016, 11:10 AM

imp accepted this revision.Aug 19 2016, 5:18 PM

imp added a reviewer: imp.

Closed by commit rS304488: Keep boot parameters in ARM trampoline code (authored by manu). · Explain WhyAug 19 2016, 6:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

arm/

elf_trampoline.c

35 lines

Diff 18957

View Options

sys/arm/arm/elf_trampoline.c

ARM : Keep boot parameters in trampoline codeClosedPublicActions