Page MenuHomeFreeBSD

ARM : Keep boot parameters in trampoline code
ClosedPublic

Authored by soutade_gmail.com on Aug 2 2016, 1:28 PM.

Details

Summary

Currently boot parameters (r0 - r3) are forgotten in ARM trampoline code. This patch save them at startup and restore them before jumping into kernel _start() routine.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

soutade_gmail.com retitled this revision from to ARM : Keep boot parameters in trampoline code.
soutade_gmail.com updated this object.
soutade_gmail.com edited the test plan for this revision. (Show Details)
soutade_gmail.com added a reviewer: bapt.
soutade_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.
soutade_gmail.com added a project: ARM.
bapt edited reviewers, added: ARM; removed: bapt.Aug 2 2016, 1:42 PM

It looks good, can you regenerate the diff as now it doesn't apply cleany ?
Thanks,

Seems reasonable to me. I added code to do this in the normal kernel, but not in the tramp code because I didn't need it. Not sure your boot environment, but it certainly doesn't hurt anything and may help.

In D7395#156870, @imp wrote:

Seems reasonable to me. I added code to do this in the normal kernel, but not in the tramp code because I didn't need it. Not sure your boot environment, but it certainly doesn't hurt anything and may help.

It's a custom bootloader with Linux boot ABI.

manu added a reviewer: manu.
This revision is now accepted and ready to land.Aug 18 2016, 11:10 AM
imp added a reviewer: imp.
This revision was automatically updated to reflect the committed changes.