Page MenuHomeFreeBSD
Differential D7395

ARM : Keep boot parameters in trampoline code
ClosedPublic
Actions

Authored by soutade_gmail.com on Aug 2 2016, 1:28 PM.
Tags
Referenced Files
F132502701: D7395.id19441.diff
Fri, Oct 17, 11:14 AM
Unknown Object (File)
Thu, Oct 16, 7:41 PM
Unknown Object (File)
Tue, Sep 30, 1:41 AM
Unknown Object (File)
Mon, Sep 29, 3:47 AM
Unknown Object (File)
Sat, Sep 27, 2:02 PM
Unknown Object (File)
Thu, Sep 25, 12:19 AM
Unknown Object (File)
Sun, Sep 21, 9:30 AM
Unknown Object (File)
Sat, Sep 20, 11:29 PM
View All Files
Subscribers
andrew
imp
manu

Details

Reviewers
manu
imp
Group Reviewers
ARM
Commits
rS331891: MFC r304488, r304623
rS304488: Keep boot parameters in ARM trampoline code
Summary

Currently boot parameters (r0 - r3) are forgotten in ARM trampoline code. This patch save them at startup and restore them before jumping into kernel _start() routine.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

soutade_gmail.com updated this revision to Diff 18957.Aug 2 2016, 1:28 PM
soutade_gmail.com retitled this revision from to ARM : Keep boot parameters in trampoline code.
soutade_gmail.com updated this object.
soutade_gmail.com edited the test plan for this revision. (Show Details)
soutade_gmail.com added a reviewer: bapt.
soutade_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.
soutade_gmail.com added a project: ARM.
Herald added subscribers: andrew, imp. · View Herald TranscriptAug 2 2016, 1:28 PM
bapt edited reviewers, added: ARM; removed: bapt.Aug 2 2016, 1:42 PM
manu added a subscriber: manu.Aug 17 2016, 7:11 PM

It looks good, can you regenerate the diff as now it doesn't apply cleany ?
Thanks,

imp added a comment.Aug 18 2016, 5:07 AM

Seems reasonable to me. I added code to do this in the normal kernel, but not in the tramp code because I didn't need it. Not sure your boot environment, but it certainly doesn't hurt anything and may help.

soutade_gmail.com updated this revision to Diff 19441.Aug 18 2016, 7:27 AM

Update diff to current HEAD

soutade_gmail.com added a comment.Aug 18 2016, 7:29 AM
In D7395#156870, @imp wrote:

Seems reasonable to me. I added code to do this in the normal kernel, but not in the tramp code because I didn't need it. Not sure your boot environment, but it certainly doesn't hurt anything and may help.

It's a custom bootloader with Linux boot ABI.

manu accepted this revision.Aug 18 2016, 11:10 AM
manu added a reviewer: manu.
This revision is now accepted and ready to land.Aug 18 2016, 11:10 AM
imp accepted this revision.Aug 19 2016, 5:18 PM
imp added a reviewer: imp.
Closed by commit rS304488: Keep boot parameters in ARM trampoline code (authored by manu). · Explain WhyAug 19 2016, 6:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
arm/
35 lines

Diff 19505

View Options

head/sys/arm/arm/elf_trampoline.c

Loading...