libfetch: Plug connection leaks in FTP code
ClosedPublic
Actions

Authored by des on Fri, Sep 25, 10:39 AM.

Tags

None

Referenced Files

	F174098088: D60017.diff
	Wed, Sep 30, 3:00 PM

	Unknown Object (File)
	Tue, Sep 29, 7:16 PM

	Unknown Object (File)
	Sat, Sep 26, 6:57 PM

	Unknown Object (File)
	Sat, Sep 26, 11:00 AM

	Unknown Object (File)
	Sat, Sep 26, 8:23 AM

	Unknown Object (File)
	Sat, Sep 26, 7:22 AM

	Unknown Object (File)
	Fri, Sep 25, 6:19 PM

	Unknown Object (File)
	Fri, Sep 25, 3:55 PM

View All 12 Files

Subscribers

imp

Details

Reviewers

markj

Commits

rG570869838f8b: libfetch: Plug connection leaks in FTP code

Summary

When setting up an FTP transfer, we need to dereference the cached
connection before returning after a failure.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77311
Build 74194: arc lint + arc unit

Event Timeline

des created this revision.Fri, Sep 25, 10:39 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Sep 25, 10:39 AM

des requested review of this revision.Fri, Sep 25, 10:39 AM

Harbormaster completed remote builds in B77311: Diff 187660.Fri, Sep 25, 10:39 AM

des added a parent revision: D60016: libfetch: Plug leak in 304 Not Modified case.Fri, Sep 25, 10:39 AM

markj accepted this revision.Wed, Sep 30, 3:09 PM

This revision is now accepted and ready to land.Wed, Sep 30, 3:09 PM

Closed by commit rG570869838f8b: libfetch: Plug connection leaks in FTP code (authored by des). · Explain WhyWed, Sep 30, 4:56 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG570869838f8b: libfetch: Plug connection leaks in FTP code.

Revision Contents
Changeset List

Path

Size

lib/

libfetch/

ftp.c

10 lines

Diff 187660

View Options

libfetch: Plug connection leaks in FTP codeClosedPublicActions