MFC after: 1 week
Fixes: 6448ec89e739 (" * limit size of buffers to RPC_MAXDATASIZE")
Fixes: e17d7ab869bb ("xdr_string: don't leak strings with xdr_free")
Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77287
Build 74170: arc lint + arc unit

Event Timeline

des created this revision.Sep 24 2026, 4:49 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 24 2026, 4:49 PM

des requested review of this revision.Sep 24 2026, 4:49 PM

Harbormaster completed remote builds in B77287: Diff 187621.Sep 24 2026, 4:49 PM

Reading this code again, I did find myself wondering if we should explictly skip the size < maxsize check in the XDR_FREE case instead of overriding maxsize.

This revision is now accepted and ready to land.Sep 25 2026, 9:25 AM

kevans accepted this revision.Sep 25 2026, 5:12 PM

Closed by commit rGd2018cedb414: xdr: Fix xdr_string. · Explain WhySep 29 2026, 12:13 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGd2018cedb414: xdr: Fix xdr_string.

markj subscribed.Sep 29 2026, 4:33 PM

markj added inline comments.