Page MenuHomeFreeBSD
Differential D59987

tests: Run unix passfd tests in parallel
AbandonedPublic
Actions

Authored by markj on Thu, Sep 24, 1:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 25, 6:16 AM
Unknown Object (File)
Fri, Sep 25, 4:15 AM
Unknown Object (File)
Fri, Sep 25, 1:45 AM
Unknown Object (File)
Fri, Sep 25, 1:18 AM
Unknown Object (File)
Thu, Sep 24, 10:57 PM
Unknown Object (File)
Thu, Sep 24, 7:57 PM
Unknown Object (File)
Thu, Sep 24, 7:48 PM
Unknown Object (File)
Thu, Sep 24, 7:17 PM
View All 9 Files
Subscribers
imp

Details

Reviewers
glebius
olivier
Summary

Commit 2d896da92a2a4 added this annotation on the basis that the
send_and_shutdown test cannot be run in parallel, but I cannot see why,
and I have not seen any failures after enabling parallelism here.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77277
Build 74160: arc lint + arc unit

Event Timeline

markj created this revision.Thu, Sep 24, 1:55 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Sep 24, 1:55 PM
markj requested review of this revision.Thu, Sep 24, 1:55 PM
Harbormaster completed remote builds in B77277: Diff 187603.Thu, Sep 24, 1:55 PM
glebius added a comment.Fri, Sep 25, 4:11 PM

That was done due to the test using kern.openfiles.

glebius added a comment.Fri, Sep 25, 4:12 PM

See 2400c536b478b

markj abandoned this revision.Fri, Sep 25, 4:19 PM
In D59987#1377117, @glebius wrote:

That was done due to the test using kern.openfiles.

Oh, I assumed that openfiles() was counting the number of fds open in the current process, not globally open files. So even with is_exclusive this is still racy, e.g., if some script runs in the background, but ok, I don't see a better solution.

Revision Contents
Changeset List

PathSize
tests/
sys/
kern/
2 lines

Diff 187603

View Options

tests/sys/kern/Makefile

Loading...