Page MenuHomeFreeBSD
Differential D59951

zfs: avoid disclosing uninitialized data in various zil functions
Needs ReviewPublic
Actions

Authored by chs on Thu, Sep 24, 12:09 AM.
Tags
None
Referenced Files
F176296679: D59951.id187548.diff
Sat, Oct 17, 6:13 PM
F176228491: D59951.id187548.diff
Sat, Oct 17, 3:44 AM
Unknown Object (File)
Thu, Oct 15, 8:33 PM
Unknown Object (File)
Wed, Oct 14, 8:57 PM
Unknown Object (File)
Wed, Oct 14, 7:16 PM
Unknown Object (File)
Tue, Oct 13, 1:00 PM
Unknown Object (File)
Sat, Oct 10, 7:01 PM
Unknown Object (File)
Fri, Oct 9, 9:52 PM
View All 26 Files
Subscribers
delphij

Details

Reviewers
imp
mav
allanjude
mm
Summary

Fully initialize all structures that are later written to the ZIL.
Found with KMSAN.

Sponsored by: Netflix
Assisted-By: Claude Code - Opus 5 (1M context)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77235
Build 74118: arc lint + arc unit

Event Timeline

chs created this revision.Thu, Sep 24, 12:09 AM
Herald added a subscriber: delphij. · View Herald TranscriptThu, Sep 24, 12:09 AM
chs requested review of this revision.Thu, Sep 24, 12:09 AM
Harbormaster completed remote builds in B77235: Diff 187548.Thu, Sep 24, 12:09 AM
chs added a parent revision: D59950: tcp: avoid disclosing uninitialize data in tcp_log code.Thu, Sep 24, 12:09 AM
chs added a child revision: D59952: linuxkpi: avoid false KMSAN report.
imp added a reviewer: mav.Tue, Sep 29, 10:24 PM

I honestly don't know if this is correct (it looks good and the code matches the comments). You'll want to get this upstreamed to openzfs though.
Added allanjude@, mav@ and mm@ since they know this code better than I.

imp added reviewers: allanjude, mm.Tue, Sep 29, 10:25 PM

Revision Contents
Changeset List

PathSize
sys/
contrib/
openzfs/
module/
zfs/
54 lines

Diff 187548

View Options

sys/contrib/openzfs/module/zfs/zfs_log.c

Loading...