Page MenuHomeFreeBSD
Differential D59877

posixshm: Fix a double unlock in shm_partial_page_invalidate()
ClosedPublic
Actions

Authored by markj on Mon, Sep 21, 4:43 PM.
Tags
None
Referenced Files
F174061955: D59877.id187511.diff
Wed, Sep 30, 7:47 AM
F174053069: D59877.diff
Wed, Sep 30, 5:59 AM
F173968552: D59877.id187346.diff
Tue, Sep 29, 5:08 PM
F173968528: D59877.id187511.diff
Tue, Sep 29, 5:08 PM
F173957457: D59877.id187346.diff
Tue, Sep 29, 3:40 PM
F173955940: D59877.diff
Tue, Sep 29, 3:28 PM
Unknown Object (File)
Tue, Sep 29, 7:59 AM
Unknown Object (File)
Tue, Sep 29, 2:24 AM
View All 30 Files
Subscribers
glebius
imp
olce

Details

Reviewers
kib
kevans
khng
Commits
rGba974faaf30b: posixshm: Fix a double unlock in shm_partial_page_invalidate()
Summary

For some reason, shm_partial_page_invalidate() unlocks the object upon
an error, but its callers don't expect this. Don't do any special error
handling. Keep the subroutine anyway since the name is a bit clearer
than vm_page_grab_zero_partial().

While here, normalize the object pointer used for locking in
shm_deallocate().

Fixes: 454bc887f250 ("uipc_shm: Implements fspacectl(2) support")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
kern/
9 lines

Diff 187511

View Options

sys/kern/uipc_shm.c

Loading...