posixshm: Fix a double unlock in shm_partial_page_invalidate()
ClosedPublic
Actions

Authored by markj on Mon, Sep 21, 4:43 PM.

Details

Reviewers

kib
kevans
khng

Commits

rGadfcef9dfe2e: posixshm: Fix a double unlock in shm_partial_page_invalidate()
rGba974faaf30b: posixshm: Fix a double unlock in shm_partial_page_invalidate()

Summary

For some reason, shm_partial_page_invalidate() unlocks the object upon
an error, but its callers don't expect this. Don't do any special error
handling. Keep the subroutine anyway since the name is a bit clearer
than vm_page_grab_zero_partial().

While here, normalize the object pointer used for locking in
shm_deallocate().

Fixes: 454bc887f250 ("uipc_shm: Implements fspacectl(2) support")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77140
Build 74023: arc lint + arc unit

Event Timeline

markj created this revision.Mon, Sep 21, 4:43 PM

Herald added subscribers: olce, glebius, imp. · View Herald TranscriptMon, Sep 21, 4:43 PM

markj requested review of this revision.Mon, Sep 21, 4:43 PM

Harbormaster completed remote builds in B77140: Diff 187346.Mon, Sep 21, 4:43 PM

kib accepted this revision.Mon, Sep 21, 6:12 PM

This revision is now accepted and ready to land.Mon, Sep 21, 6:12 PM

Closed by commit rGba974faaf30b: posixshm: Fix a double unlock in shm_partial_page_invalidate() (authored by markj). · Explain WhyWed, Sep 23, 4:55 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGba974faaf30b: posixshm: Fix a double unlock in shm_partial_page_invalidate().

markj added a commit: rGadfcef9dfe2e: posixshm: Fix a double unlock in shm_partial_page_invalidate().Thu, Oct 1, 3:20 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_shm.c

9 lines

Diff 187346

View Options

posixshm: Fix a double unlock in shm_partial_page_invalidate()ClosedPublicActions