There is no need at all to load the cuse module to just access the tool help.
kldload always checks for permissions first returning -EPERM if the user can't
load modules and -EEXIST if the user can, but the module is already loaded.
Details
Details
- Reviewers
christos - Group Reviewers
audio - Commits
- rGb8b23cf1122e: virtual_oss(8): Fix cuse.ko check
rG5aac18d0faec: virtual_oss(8): Fix cuse.ko check
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 77119 Build 74002: arc lint + arc unit
Event Timeline
| usr.sbin/virtual_oss/virtual_oss/main.c | ||
|---|---|---|
| 2588 | Not really. See obiwac comment about it in https://reviews.freebsd.org/D59621 | |
| usr.sbin/virtual_oss/virtual_oss/main.c | ||
|---|---|---|
| 2588 | Minor nit: this could be part of the if above with an additional &&. | |
| usr.sbin/virtual_oss/virtual_oss/main.c | ||
|---|---|---|
| 2588 | ||
Comment Actions
Please also take care of MFC'ing to stable/15 this at some point, ideally after 1-2 weeks.