Page MenuHomeFreeBSD
Differential D59844

virtual_oss(8): Fix cuse.ko check
ClosedPublic
Actions

Authored by fernape on Sat, Sep 19, 4:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 26, 10:19 PM
Unknown Object (File)
Sat, Sep 26, 5:21 PM
Unknown Object (File)
Sat, Sep 26, 8:55 AM
Unknown Object (File)
Sat, Sep 26, 7:39 AM
Unknown Object (File)
Sat, Sep 26, 7:10 AM
Unknown Object (File)
Sat, Sep 26, 7:10 AM
Unknown Object (File)
Sat, Sep 26, 7:09 AM
Unknown Object (File)
Sat, Sep 26, 7:09 AM
View All 46 Files
Subscribers
imp

Details

Reviewers
christos
Group Reviewers
audio
Commits
rG5aac18d0faec: virtual_oss(8): Fix cuse.ko check
Summary

There is no need at all to load the cuse module to just access the tool help.

kldload always checks for permissions first returning -EPERM if the user can't
load modules and -EEXIST if the user can, but the module is already loaded.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77123
Build 74006: arc lint + arc unit

Event Timeline

fernape created this revision.Sat, Sep 19, 4:43 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, Sep 19, 4:43 PM
Harbormaster completed remote builds in B77093: Diff 187239.Sat, Sep 19, 4:43 PM
fernape requested review of this revision.Sat, Sep 19, 4:43 PM
fernape added reviewers: audio, christos.Sat, Sep 19, 4:44 PM
fernape mentioned this in D59621: virtual_oss(8): Fix cuse.ko check.Sat, Sep 19, 4:47 PM
christos added inline comments.Sun, Sep 20, 3:17 PM
usr.sbin/virtual_oss/virtual_oss/main.c
2588

The function name makes it obvious what the code is doing, the comment is redundant.

2590
2592

Also redundant.

fernape updated this revision to Diff 187283.Sun, Sep 20, 4:24 PM

Remove comments

Harbormaster completed remote builds in B77119: Diff 187283.Sun, Sep 20, 4:24 PM
christos accepted this revision.Sun, Sep 20, 4:25 PM

LGTM, but don't commit it until we have resolved the discussion in D59621.

This revision is now accepted and ready to land.Sun, Sep 20, 4:25 PM
fernape updated this revision to Diff 187284.Sun, Sep 20, 4:25 PM

Reuse variable in error message.

This revision now requires review to proceed.Sun, Sep 20, 4:25 PM
Harbormaster completed remote builds in B77120: Diff 187284.Sun, Sep 20, 4:25 PM
fernape marked 2 inline comments as done.Sun, Sep 20, 4:25 PM
fernape added inline comments.
usr.sbin/virtual_oss/virtual_oss/main.c
2588

Not really. See obiwac comment about it in https://reviews.freebsd.org/D59621

christos added inline comments.Sun, Sep 20, 4:26 PM
usr.sbin/virtual_oss/virtual_oss/main.c
2588

Minor nit: this could be part of the if above with an additional &&.

fernape updated this revision to Diff 187297.Sun, Sep 20, 6:18 PM

Use one single if statement.

Harbormaster completed remote builds in B77123: Diff 187297.Sun, Sep 20, 6:18 PM
fernape marked an inline comment as done.Sun, Sep 20, 6:19 PM
christos added inline comments.Mon, Sep 21, 11:06 AM
usr.sbin/virtual_oss/virtual_oss/main.c
2588
fernape updated this revision to Diff 187430.Tue, Sep 22, 3:20 PM

Fix style.

Harbormaster completed remote builds in B77187: Diff 187430.Tue, Sep 22, 3:20 PM
fernape marked an inline comment as done.Tue, Sep 22, 3:21 PM
christos accepted this revision.Tue, Sep 22, 3:33 PM

Please also take care of MFC'ing to stable/15 this at some point, ideally after 1-2 weeks.

This revision is now accepted and ready to land.Tue, Sep 22, 3:33 PM
Closed by commit rG5aac18d0faec: virtual_oss(8): Fix cuse.ko check (authored by fernape). · Explain WhyFri, Sep 25, 3:51 PM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rG5aac18d0faec: virtual_oss(8): Fix cuse.ko check.

Revision Contents
Changeset List

PathSize
usr.sbin/
virtual_oss/
virtual_oss/
7 lines

Diff 187297

View Options

usr.sbin/virtual_oss/virtual_oss/main.c

Loading...