loader.efi: Be cautious about using GOPs
ClosedPublic
Actions

Authored by imp on Sat, Sep 19, 3:47 AM.

Details

Reviewers

seuros
chs
mav
chuck
manu

Commits

rGb5f0e7f36afc: loader.efi: Be cautious about using GOPs

Summary

When we're searching for the EFI_GRAPHICS_OUTPUT_PROTOCOL_GUID (GOPs) to
use, skip any whose Mode or Mode->Info pointers are NULL. The spec
requires these to be non-null, however, some firmwares seem to fail to
populate the Info when, for example, a monitor is not present. Work
around these bugs by skipping any GOPs with bad pointers.

PR: 288900
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77077
Build 73960: arc lint + arc unit

Event Timeline

imp created this revision.Sat, Sep 19, 3:47 AM

Herald added a reviewer: manu. · View Herald TranscriptSat, Sep 19, 3:47 AM

Herald added subscribers: dab, bcran. · View Herald Transcript

imp requested review of this revision.Sat, Sep 19, 3:47 AM

Harbormaster completed remote builds in B77077: Diff 187194.Sat, Sep 19, 3:47 AM

imp added a parent revision: D59829: nvme: honor Linux passthrough command timeouts.Sat, Sep 19, 3:47 AM

imp added a child revision: D59831: nvme: Refactor namespace notifications for additions.

Seems odd to me that this loader.efi / GOP related change is in the middle of a stack of nmve related updates: it looks completely independent. Did the wrong change show up in the stack?

seuros removed a child revision: D59831: nvme: Refactor namespace notifications for additions.Sat, Sep 19, 7:00 PM

seuros removed a parent revision: D59829: nvme: honor Linux passthrough command timeouts.

In D59830#1373143, @markmi_dsl-only.net wrote:

Seems odd to me that this loader.efi / GOP related change is in the middle of a stack of nmve related updates: it looks completely independent. Did the wrong change show up in the stack?

Too many branches, so I just added to the one I was working on since the alternative was that it would likely get lost.

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Sep 24, 7:24 AM

Closed by commit rGb5f0e7f36afc: loader.efi: Be cautious about using GOPs (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGb5f0e7f36afc: loader.efi: Be cautious about using GOPs.