Paths

Table of Contentst

Differential D59453

tcp: use sparse initializer for host cache metrics
ClosedPublic
Actions

Authored by glebius on Sat, Sep 5, 5:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 3, 9:19 PM

	Unknown Object (File)
	Sat, Oct 3, 7:27 PM

	Unknown Object (File)
	Sat, Oct 3, 3:11 AM

	Unknown Object (File)
	Fri, Oct 2, 2:51 PM

	Unknown Object (File)
	Thu, Oct 1, 9:31 PM

	Unknown Object (File)
	Thu, Oct 1, 1:22 PM

	Unknown Object (File)
	Sun, Sep 27, 3:25 AM

	Unknown Object (File)
	Sat, Sep 26, 5:57 AM

View All 59 Files

Subscribers

Details

Reviewers

rscheff
tuexen

Group Reviewers

Commits

rG597798a0e5ff: tcp: use sparse initializer for host cache metrics

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Sat, Sep 5, 5:45 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptSat, Sep 5, 5:45 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Sat, Sep 5, 5:45 PM

Harbormaster completed remote builds in B76576: Diff 185942.Sat, Sep 5, 5:45 PM

glebius added a parent revision: D59452: tcp: turn on TCP hostcache for socket buffer sizes.Sat, Sep 5, 5:45 PM

glebius added a child revision: D59454: tcp: provide tcp_rttupdated() and call it periodically.

tuexen added a subscriber: tuexen.Sat, Sep 5, 6:32 PM

tuexen added inline comments.

sys/netinet/tcp_subr.c
2518	This is declaring a variable in the middle of the block. Why don't you perform this initialization at the beginning of the `if` block (where the declaration was) and only update `hc_ssthresh` here to `ssthresh`?

glebius added inline comments.Sat, Sep 5, 6:42 PM

sys/netinet/tcp_subr.c
2518	This will make the compiler first write a zero to hc_ssthresh, then a new value. I can actually go without a variable at all, make entire declaration an argument to tcp_hc_update().

tuexen added inline comments.Sat, Sep 5, 6:59 PM

sys/netinet/tcp_subr.c
2518	Then I would prefer going without a variable...

No local variable at all.

Harbormaster completed remote builds in B76583: Diff 185952.Sat, Sep 5, 7:06 PM

tuexen accepted this revision.Sat, Sep 5, 7:43 PM

This revision is now accepted and ready to land.Sat, Sep 5, 7:43 PM

Closed by commit rG597798a0e5ff: tcp: use sparse initializer for host cache metrics (authored by glebius). · Explain WhyFri, Sep 18, 10:02 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG597798a0e5ff: tcp: use sparse initializer for host cache metrics.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

19 lines

Diff 187153

sys/netinet/tcp_subr.c

Loading...