acpi: Don't check suspend-to-idle if suspend failed
ClosedPublic
Actions

Authored by obiwac on Wed, Sep 16, 5:10 PM.

Details

Reviewers

Commits

rGc9bfc37b61d2: acpi: Don't check suspend-to-idle if suspend failed

Summary

If we e.g. failed to suspend a device and suspend bounced because of
that, then we're not expected to have entered a deep sleep state in the
first place. In this situation, don't overload the user with irrelevant
information.

Fixes: 5f68acc931a4 ("acpi: Warn if no amdsmu(4) loaded after suspend-to-idle resume")
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76981
Build 73864: arc lint + arc unit

Event Timeline

obiwac created this revision.Wed, Sep 16, 5:10 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Sep 16, 5:10 PM

obiwac requested review of this revision.Wed, Sep 16, 5:10 PM

Harbormaster completed remote builds in B76981: Diff 186892.Wed, Sep 16, 5:10 PM

obiwac added a parent revision: D59735: acpi: Set status to AE_ERROR if device suspend failed.Wed, Sep 16, 5:46 PM

obiwac added a child revision: D59741: acpi: Invoke power_resume_check eventhandler.Wed, Sep 16, 6:52 PM

olce accepted this revision.Fri, Sep 18, 7:31 AM

This revision is now accepted and ready to land.Fri, Sep 18, 7:31 AM

Closed by commit rGc9bfc37b61d2: acpi: Don't check suspend-to-idle if suspend failed (authored by obiwac). · Explain WhyFri, Sep 18, 10:59 AM

This revision was automatically updated to reflect the committed changes.

obiwac added a commit: rGc9bfc37b61d2: acpi: Don't check suspend-to-idle if suspend failed.

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

acpi.c

2 lines

Diff 186892

View Options

acpi: Don't check suspend-to-idle if suspend failedClosedPublicActions