Page MenuHomeFreeBSD
Differential D7278

ctld(8): Fix MaxBurstLength negotiation.
ClosedPublic
Actions

Authored by np on Jul 22 2016, 1:12 AM.
Tags
None
Referenced Files
F106655082: D7278.diff
Fri, Jan 3, 11:21 AM
Unknown Object (File)
Wed, Dec 11, 3:38 PM
Unknown Object (File)
Nov 3 2024, 3:59 PM
Unknown Object (File)
Nov 3 2024, 3:59 PM
Unknown Object (File)
Nov 3 2024, 3:58 PM
Unknown Object (File)
Nov 3 2024, 3:58 PM
Unknown Object (File)
Nov 3 2024, 3:36 PM
Unknown Object (File)
Nov 2 2024, 6:58 AM
View All 69 Files
Subscribers
imp

Details

Reviewers
ken
trasz
mav
jpaetzel
Commits
rS303311: MFC r303199:
rS303199: ctld(8): Fix MaxBurstLength negotiation.
Summary

The target must reply with the selected value of MaxBurstSize instead of
just echoing back the initiator's offered value.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4559
Build 4611: arc lint + arc unit

Event Timeline

np updated this revision to Diff 18647.Jul 22 2016, 1:12 AM
np retitled this revision from to ctld(8): Fix MaxBurstLength negotiation..
np updated this object.
np edited the test plan for this revision. (Show Details)
np added reviewers: trasz, mav, jpaetzel, ken.
Herald added a subscriber: imp. · View Herald TranscriptJul 22 2016, 1:12 AM
mav accepted this revision.Jul 22 2016, 5:48 AM
mav edited edge metadata.

It makes sense, though barely change anything.

This revision is now accepted and ready to land.Jul 22 2016, 5:48 AM
np added a comment.Jul 22 2016, 3:10 PM
In D7278#151397, @mav wrote:

It makes sense, though barely change anything.

If the initiator has a higher limit than the FreeBSD ctld target then the target will internally lower its MaxBurstLength but echo back the higher value to the initiator, causing the two sides to disagree on what MaxBurstLength really is.

mav added a comment.EditedJul 22 2016, 3:25 PM
In D7278#151489, @np wrote:
In D7278#151397, @mav wrote:

It makes sense, though barely change anything.

If the initiator has a higher limit than the FreeBSD ctld target then the target will internally lower its MaxBurstLength but echo back the higher value to the initiator, causing the two sides to disagree on what MaxBurstLength really is.

Sure, I just wanted to say that at this point it is not probably breaking anything. CTL uses this value only to limit transmissions, so limiting lower then remote size expects is not a problem. For receive CTL has no any limit now, so it also don't harm. But yes, it should be fixed.

Closed by commit rS303199: ctld(8): Fix MaxBurstLength negotiation. (authored by np). · Explain WhyJul 22 2016, 7:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.sbin/
ctld/
2 lines

Diff 18647

View Options

usr.sbin/ctld/login.c

Loading...