Page MenuHomeFreeBSD

ctld(8): Fix MaxBurstLength negotiation.
ClosedPublic

Authored by np on Jul 22 2016, 1:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 4:19 AM
Unknown Object (File)
Jan 8 2024, 9:13 PM
Unknown Object (File)
Jan 8 2024, 9:13 PM
Unknown Object (File)
Jan 8 2024, 9:13 PM
Unknown Object (File)
Jan 8 2024, 8:39 PM
Unknown Object (File)
Dec 22 2023, 9:03 PM
Unknown Object (File)
Dec 22 2023, 7:39 AM
Unknown Object (File)
Dec 12 2023, 7:14 PM
Subscribers

Details

Summary

The target must reply with the selected value of MaxBurstSize instead of
just echoing back the initiator's offered value.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

np retitled this revision from to ctld(8): Fix MaxBurstLength negotiation..
np updated this object.
np edited the test plan for this revision. (Show Details)
np added reviewers: trasz, mav, jpaetzel, ken.
mav edited edge metadata.

It makes sense, though barely change anything.

This revision is now accepted and ready to land.Jul 22 2016, 5:48 AM
In D7278#151397, @mav wrote:

It makes sense, though barely change anything.

If the initiator has a higher limit than the FreeBSD ctld target then the target will internally lower its MaxBurstLength but echo back the higher value to the initiator, causing the two sides to disagree on what MaxBurstLength really is.

In D7278#151489, @np wrote:
In D7278#151397, @mav wrote:

It makes sense, though barely change anything.

If the initiator has a higher limit than the FreeBSD ctld target then the target will internally lower its MaxBurstLength but echo back the higher value to the initiator, causing the two sides to disagree on what MaxBurstLength really is.

Sure, I just wanted to say that at this point it is not probably breaking anything. CTL uses this value only to limit transmissions, so limiting lower then remote size expects is not a problem. For receive CTL has no any limit now, so it also don't harm. But yes, it should be fixed.

This revision was automatically updated to reflect the committed changes.